execution payload helper now with single object arg

Author: nicktrn

apps/webapp/app/v3/failedTaskRun.server.ts

@@ -146,12 +146,11 @@ export class FailedTaskRunService extends BaseService {
 
     // We already have an attempt with non-final status, let's use it
     try {
-      const executionPayload = await sharedQueueTasks.getExecutionPayloadFromAttempt(
-        attempt.id,
-        undefined,
-        undefined,
-        true
-      );
+      const executionPayload = await sharedQueueTasks.getExecutionPayloadFromAttempt({
+        id: attempt.id,
+        skipStatusChecks: true,
+      });
+
       return executionPayload?.execution;
     } catch (error) {
       logger.error("[FailedTaskRunService] Failed to get execution payload", {

apps/webapp/app/v3/handleSocketIo.server.ts

@@ -195,7 +195,10 @@ function createCoordinatorNamespace(io: Server) {
           const service = new CreateTaskRunAttemptService();
           const { attempt } = await service.call(message.runId, environment, false);
 
-          const payload = await sharedQueueTasks.getExecutionPayloadFromAttempt(attempt.id, true);
+          const payload = await sharedQueueTasks.getExecutionPayloadFromAttempt({
+            id: attempt.id,
+            setToExecuting: true,
+          });
 
           if (!payload) {
             logger.error("Failed to retrieve payload after attempt creation", message);

apps/webapp/app/v3/marqs/sharedQueueConsumer.server.ts

@@ -718,9 +718,9 @@ export class SharedQueueConsumer {
 
           completions.push(completion);
 
-          const executionPayload = await this._tasks.getExecutionPayloadFromAttempt(
-            completedAttempt.id
-          );
+          const executionPayload = await this._tasks.getExecutionPayloadFromAttempt({
+            id: completedAttempt.id,
+          });
 
           if (!executionPayload) {
             await this.#ackAndDoMoreWork(message.messageId);
@@ -942,12 +942,17 @@ class SharedQueueTasks {
     }
   }
 
-  async getExecutionPayloadFromAttempt(
-    id: string,
-    setToExecuting?: boolean,
-    isRetrying?: boolean,
-    skipStatusChecks?: boolean
-  ): Promise<ProdTaskRunExecutionPayload | undefined> {
+  async getExecutionPayloadFromAttempt({
+    id,
+    setToExecuting,
+    isRetrying,
+    skipStatusChecks,
+  }: {
+    id: string;
+    setToExecuting?: boolean;
+    isRetrying?: boolean;
+    skipStatusChecks?: boolean;
+  }): Promise<ProdTaskRunExecutionPayload | undefined> {
     const attempt = await prisma.taskRunAttempt.findUnique({
       where: {
         id,
@@ -1153,7 +1158,11 @@ class SharedQueueTasks {
       return;
     }
 
-    return this.getExecutionPayloadFromAttempt(latestAttempt.id, setToExecuting, isRetrying);
+    return this.getExecutionPayloadFromAttempt({
+      id: latestAttempt.id,
+      setToExecuting,
+      isRetrying,
+    });
   }
 
   async getLazyAttemptPayload(

apps/webapp/app/v3/services/resumeAttempt.server.ts

@@ -207,9 +207,9 @@ export class ResumeAttemptService extends BaseService {
 
       completions.push(completion);
 
-      const executionPayload = await sharedQueueTasks.getExecutionPayloadFromAttempt(
-        completedAttempt.id
-      );
+      const executionPayload = await sharedQueueTasks.getExecutionPayloadFromAttempt({
+        id: completedAttempt.id,
+      });
 
       if (!executionPayload) {
         logger.error("Failed to get execution payload", {