-
-
Notifications
You must be signed in to change notification settings - Fork 891
Changeset for the envvar function isSecret support #1942
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…et for each value. Secret values are always redacted.
🦋 Changeset detectedLatest commit: 5cedc7f The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
WalkthroughThis update modifies the behavior of the Changes
Poem
Tip ⚡💬 Agentic Chat (Pro Plan, General Availability)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
.changeset/green-lions-relate.md (1)
5-5: Clarify function naming in description
The description referencesenvvars.list()but only saysretrieve(). It’s clearer to fully qualify both methods and to wrap identifiers in backticks.Proposed revision:
- The envvars.list() and retrieve() functions receive isSecret for each value. Secret values are always redacted. + The `envvars.list()` and `envvars.retrieve()` functions receive an `isSecret` flag for each value. Secret values are always redacted.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.changeset/green-lions-relate.md(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (7)
- GitHub Check: e2e / 🧪 CLI v3 tests (windows-latest - pnpm)
- GitHub Check: e2e / 🧪 CLI v3 tests (windows-latest - npm)
- GitHub Check: e2e / 🧪 CLI v3 tests (ubuntu-latest - pnpm)
- GitHub Check: e2e / 🧪 CLI v3 tests (ubuntu-latest - npm)
- GitHub Check: typecheck / typecheck
- GitHub Check: units / 🧪 Unit Tests
- GitHub Check: Analyze (javascript-typescript)
🔇 Additional comments (1)
.changeset/green-lions-relate.md (1)
1-3: Validate changeset header formatting
The frontmatter correctly specifies a patch bump for@trigger.dev/sdk. Ensure there’s no unintended whitespace or indentation in the YAML delimiters.
The envvars.list() and retrieve() functions receive isSecret for each value. Secret values are always redacted.
Summary by CodeRabbit
isSecretflag and are always redacted if marked as secret, improving protection of sensitive information.