Potential fix for code scanning alert no. 391: Incorrect conversion between integer types

joel-rieke · github-advanced-security[bot] · web-flow · commit 044b28109866 · 2025-07-15T15:36:41.000-07:00
Co-authored-by: Copilot Autofix powered by AI &lt;62310815+github-advanced-security[bot]@users.noreply.github.com&gt;
diff --git a/sql/yeartype.go b/sql/yeartype.go
@@ -116,7 +116,7 @@ func (t yearType) Convert(v interface{}) (interface{}, error) {
 		if value < float64(math.MinInt16) || value > float64(math.MaxInt16) {
 			return nil, ErrConvertingToYear.New("float64 value out of bounds for int16")
 		}
-		return t.Convert(int16(value))
+		return int16(value), nil
 	case decimal.Decimal:
 		return t.Convert(value.IntPart())
 	case decimal.NullDecimal:

Original file line number	Diff line number	Diff line change
`@@ -116,7 +116,7 @@ func (t yearType) Convert(v interface{}) (interface{}, error) {`
`116`	`116`	`if value < float64(math.MinInt16) \|\| value > float64(math.MaxInt16) {`
`117`	`117`	`return nil, ErrConvertingToYear.New("float64 value out of bounds for int16")`
`118`	`118`	`}`
`119`		`- return t.Convert(int16(value))`
	`119`	`+ return int16(value), nil`
`120`	`120`	`case decimal.Decimal:`
`121`	`121`	`return t.Convert(value.IntPart())`
`122`	`122`	`case decimal.NullDecimal:`