Potential fix for code scanning alert no. 399: Incorrect conversion between integer types

joel-rieke · github-advanced-security[bot] · web-flow · commit 3b6494ee3aee · 2025-07-15T15:57:47.000-07:00
Co-authored-by: Copilot Autofix powered by AI &lt;62310815+github-advanced-security[bot]@users.noreply.github.com&gt;
diff --git a/sql/yeartype.go b/sql/yeartype.go
@@ -117,7 +117,7 @@ func (t yearType) Convert(v interface{}) (interface{}, error) {
 			return nil, ErrConvertingToYear.New("float64 value out of bounds for int16")
 		}
 		// Check for fractional part
-		if value != float64(int16(value)) {
+		if value != math.Trunc(value) {
 			return nil, ErrConvertingToYear.New("float64 value has a fractional component, cannot convert to int16")
 		}
 		return int16(value), nil

Original file line number	Diff line number	Diff line change
`@@ -117,7 +117,7 @@ func (t yearType) Convert(v interface{}) (interface{}, error) {`
`117`	`117`	`return nil, ErrConvertingToYear.New("float64 value out of bounds for int16")`
`118`	`118`	`}`
`119`	`119`	`// Check for fractional part`
`120`		`- if value != float64(int16(value)) {`
	`120`	`+ if value != math.Trunc(value) {`
`121`	`121`	`return nil, ErrConvertingToYear.New("float64 value has a fractional component, cannot convert to int16")`
`122`	`122`	`}`
`123`	`123`	`return int16(value), nil`