Potential fix for code scanning alert no. 396: Incorrect conversion between integer types

joel-rieke · github-advanced-security[bot] · web-flow · commit 4a2ac395e1a1 · 2025-07-15T15:51:14.000-07:00
Co-authored-by: Copilot Autofix powered by AI &lt;62310815+github-advanced-security[bot]@users.noreply.github.com&gt;
diff --git a/sql/system_enumtype.go b/sql/system_enumtype.go
@@ -104,7 +104,7 @@ func (t systemEnumType) Convert(v interface{}) (interface{}, error) {
 	case float64:
 		// Float values aren't truly accepted, but the engine will give them when it should give ints.
 		// Therefore, if the float doesn't have a fractional portion, we treat it as an int.
-		if value >= float64(math.MinInt) && value <= float64(math.MaxInt) && value == float64(int(value)) {
+		if value >= 0 && value <= float64(math.MaxInt) && value == float64(int(value)) {
 			return t.Convert(int(value))
 		}
 		return nil, ErrInvalidSystemVariableValue.New(t.varName, value)

Original file line number	Diff line number	Diff line change
`@@ -104,7 +104,7 @@ func (t systemEnumType) Convert(v interface{}) (interface{}, error) {`
`104`	`104`	`case float64:`
`105`	`105`	`// Float values aren't truly accepted, but the engine will give them when it should give ints.`
`106`	`106`	`// Therefore, if the float doesn't have a fractional portion, we treat it as an int.`
`107`		`- if value >= float64(math.MinInt) && value <= float64(math.MaxInt) && value == float64(int(value)) {`
	`107`	`+ if value >= 0 && value <= float64(math.MaxInt) && value == float64(int(value)) {`
`108`	`108`	`return t.Convert(int(value))`
`109`	`109`	`}`
`110`	`110`	`return nil, ErrInvalidSystemVariableValue.New(t.varName, value)`