Merge pull request #26 from trimble-oss/alert-autofix-268

Potential fix for code scanning alert no. 268: Incorrect conversion between integer types

Author: joel-rieke

sql/system_settype.go

@@ -90,12 +90,13 @@ func (t systemSetType) Convert(v interface{}) (interface{}, error) {
 	case float64:
 		// Float values aren't truly accepted, but the engine will give them when it should give ints.
 		// Therefore, if the float doesn't have a fractional portion, we treat it as an int.
-		if value == float64(int64(value)) {
-			if value < float64(math.MinInt64) || value > float64(math.MaxInt64) {
-				return nil, ErrInvalidSystemVariableValue.New(t.varName, v)
+		if value >= float64(math.MinInt64) && value <= float64(math.MaxInt64) {
+			intValue := int64(value)
+			if float64(intValue) == value {
+				return t.SetType.Convert(intValue)
 			}
-			return t.SetType.Convert(int64(value))
 		}
+		return nil, ErrInvalidSystemVariableValue.New(t.varName, v)
 	case decimal.Decimal:
 		f, _ := value.Float64()
 		return t.Convert(f)