Merge pull request #23 from trimble-oss/alert-autofix-253

Potential fix for code scanning alert no. 253: Incorrect conversion between integer types

Author: joel-rieke

sql/yeartype.go

@@ -15,14 +15,14 @@
 package sql
 
 import (
+	"math"
 	"reflect"
 	"strconv"
 	"time"
 
-	"github.com/shopspring/decimal"
-
 	"github.com/dolthub/vitess/go/sqltypes"
 	"github.com/dolthub/vitess/go/vt/proto/query"
+	"github.com/shopspring/decimal"
 	"gopkg.in/src-d/go-errors.v1"
 )
 
@@ -110,6 +110,9 @@ func (t yearType) Convert(v interface{}) (interface{}, error) {
 	case float32:
 		return t.Convert(int64(value))
 	case float64:
+		if value < float64(math.MinInt64) || value > float64(math.MaxInt64) {
+			return nil, ErrConvertingToYear.New("float64 value out of bounds for int64")
+		}
 		return t.Convert(int64(value))
 	case decimal.Decimal:
 		return t.Convert(value.IntPart())