Potential fix for code scanning alert no. 277: Incorrect conversion between integer types

joel-rieke · github-advanced-security[bot] · web-flow · commit aeaaec97bc3e · 2025-07-15T13:30:50.000-07:00
Co-authored-by: Copilot Autofix powered by AI &lt;62310815+github-advanced-security[bot]@users.noreply.github.com&gt;
diff --git a/sql/expression/bit_ops.go b/sql/expression/bit_ops.go
@@ -189,6 +189,9 @@ func convertUintFromInt(n int64) uint64 {
 	if err != nil {
 		return 0
 	}
+	if uintVal > math.MaxInt64 {
+		return 0 // Out of range for int64
+	}
 	return uintVal
 }
 
diff --git a/sql/system_booltype.go b/sql/system_booltype.go
@@ -108,6 +108,7 @@ func (t systemBoolType) Convert(v interface{}) (interface{}, error) {
 					return int8(intVal), nil
 				}
 				return nil, ErrInvalidSystemVariableValue.New(t.varName, v)
+				return nil, ErrInvalidSystemVariableValue.New(t.varName, v)
 			}
 			return nil, ErrInvalidSystemVariableValue.New(t.varName, v)
 		}

Original file line number	Diff line number	Diff line change
`@@ -189,6 +189,9 @@ func convertUintFromInt(n int64) uint64 {`
`189`	`189`	`if err != nil {`
`190`	`190`	`return 0`
`191`	`191`	`}`
	`192`	`+ if uintVal > math.MaxInt64 {`
	`193`	`+ return 0 // Out of range for int64`
	`194`	`+ }`
`192`	`195`	`return uintVal`
`193`	`196`	`}`
`194`	`197`
Original file line number	Diff line number	Diff line change
`@@ -108,6 +108,7 @@ func (t systemBoolType) Convert(v interface{}) (interface{}, error) {`
`108`	`108`	`return int8(intVal), nil`
`109`	`109`	`}`
`110`	`110`	`return nil, ErrInvalidSystemVariableValue.New(t.varName, v)`
	`111`	`+ return nil, ErrInvalidSystemVariableValue.New(t.varName, v)`
`111`	`112`	`}`
`112`	`113`	`return nil, ErrInvalidSystemVariableValue.New(t.varName, v)`
`113`	`114`	`}`