Potential fix for code scanning alert no. 274: Incorrect conversion between integer types

joel-rieke · github-advanced-security[bot] · web-flow · commit f8d4eb192f72 · 2025-07-15T13:20:24.000-07:00
Co-authored-by: Copilot Autofix powered by AI &lt;62310815+github-advanced-security[bot]@users.noreply.github.com&gt;
diff --git a/sql/system_booltype.go b/sql/system_booltype.go
@@ -103,8 +103,9 @@ func (t systemBoolType) Convert(v interface{}) (interface{}, error) {
 		// Therefore, if the float doesn't have a fractional portion, we treat it as an int.
 		if value == float64(int64(value)) {
 			if value >= float64(math.MinInt64) && value <= float64(math.MaxInt64) {
-				if intVal := int64(value); intVal >= math.MinInt8 && intVal <= math.MaxInt8 {
-					return t.Convert(intVal)
+				intVal := int64(value)
+				if intVal >= math.MinInt8 && intVal <= math.MaxInt8 {
+					return int8(intVal), nil
 				}
 				return nil, ErrInvalidSystemVariableValue.New(t.varName, v)
 			}

Original file line number	Diff line number	Diff line change
`@@ -103,8 +103,9 @@ func (t systemBoolType) Convert(v interface{}) (interface{}, error) {`
`103`	`103`	`// Therefore, if the float doesn't have a fractional portion, we treat it as an int.`
`104`	`104`	`if value == float64(int64(value)) {`
`105`	`105`	`if value >= float64(math.MinInt64) && value <= float64(math.MaxInt64) {`
`106`		`- if intVal := int64(value); intVal >= math.MinInt8 && intVal <= math.MaxInt8 {`
`107`		`- return t.Convert(intVal)`
	`106`	`+ intVal := int64(value)`
	`107`	`+ if intVal >= math.MinInt8 && intVal <= math.MaxInt8 {`
	`108`	`+ return int8(intVal), nil`
`108`	`109`	`}`
`109`	`110`	`return nil, ErrInvalidSystemVariableValue.New(t.varName, v)`
`110`	`111`	`}`