Potential fix for code scanning alert no. 368: Potentially unsafe quoting #30
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/trimble-oss/go-mysql-server/security/code-scanning/368
To fix this issue, we need to ensure that single quotes and other potentially dangerous characters in
vare escaped correctly before being embedded into the SQL query string. This can be achieved by using a dedicated sanitization mechanism such asstrings.ReplaceAllor adopting a structured API that avoids manual string construction.Best way to fix:
vusingstrings.ReplaceAllto ensure that embedded quotes do not break the SQL structure.fmt.Sprintf("'%v'", v)with a sanitized version ofvwhere single quotes and backslashes are appropriately escaped.convertColumnDefaultToStringfunction.Required changes:
strings.ReplaceAllin theconvertColumnDefaultToStringfunction insql/rowexec/show_iters.go.Suggested fixes powered by Copilot Autofix. Review carefully before merging.