Skip to content

Commit bafdcf7

Browse files
committed
service: seperate coordinator and worker service
Signed-off-by: Parsa Yousefi <[email protected]>
1 parent 2856eba commit bafdcf7

File tree

5 files changed

+41
-7
lines changed

5 files changed

+41
-7
lines changed

charts/trino/README.md

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -436,6 +436,14 @@ Fast distributed SQL query engine for big data analytics that helps you explore
436436
A list of the Linux kernel capabilities that are dropped from every container. Valid values are listed in [the capabilities manual page](https://man7.org/linux/man-pages/man7/capabilities.7.html). Ensure # to remove the "CAP_" prefix which the kernel attaches to the names of permissions.
437437
* `shareProcessNamespace.coordinator` - bool, default: `false`
438438
* `shareProcessNamespace.worker` - bool, default: `false`
439+
* `serviceCoordinator.annotations` - object, default: `{}`
440+
* `serviceCoordinator.type` - string, default: `"ClusterIP"`
441+
* `serviceCoordinator.port` - int, default: `8080`
442+
* `serviceCoordinator.nodePort` - string, default: `""`
443+
* `serviceWorker.annotations` - object, default: `{}`
444+
* `serviceWorker.type` - string, default: `"ClusterIP"`
445+
* `serviceWorker.port` - int, default: `8080`
446+
* `serviceWorker.nodePort` - string, default: `""`
439447
* `service.annotations` - object, default: `{}`
440448
* `service.type` - string, default: `"ClusterIP"`
441449
* `service.port` - int, default: `8080`

charts/trino/templates/service-coordinator.yaml

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
{{- $svc := .Values.serviceCoordinator | default .Values.service }}
12
{{- $coordinatorJmx := merge .Values.jmx.coordinator (omit .Values.jmx "coordinator" "worker") -}}
23
apiVersion: v1
34
kind: Service
@@ -8,16 +9,16 @@ metadata:
89
{{- include "trino.labels" . | nindent 4 }}
910
app.kubernetes.io/component: coordinator
1011
annotations:
11-
{{- toYaml .Values.service.annotations | nindent 4 }}
12+
{{- toYaml $svc.annotations | nindent 4 }}
1213
spec:
13-
type: {{ .Values.service.type }}
14+
type: {{ $svc.type }}
1415
ports:
15-
- port: {{ .Values.service.port }}
16+
- port: {{ $svc.port }}
1617
targetPort: http
1718
protocol: TCP
1819
name: http
19-
{{- if .Values.service.nodePort }}
20-
nodePort: {{ .Values.service.nodePort }}
20+
{{- if $svc.nodePort }}
21+
nodePort: {{ $svc.nodePort }}
2122
{{- end }}
2223
{{- if .Values.server.config.https.enabled }}
2324
- port: {{ .Values.server.config.https.port }}

charts/trino/templates/service-worker.yaml

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
{{- $svc := .Values.serviceWorker | default .Values.service }}
12
{{- $workerJmx := merge .Values.jmx.worker (omit .Values.jmx "coordinator" "worker") -}}
23
apiVersion: v1
34
kind: Service
@@ -8,11 +9,11 @@ metadata:
89
{{- include "trino.labels" . | nindent 4 }}
910
app.kubernetes.io/component: worker
1011
annotations:
11-
{{- toYaml .Values.service.annotations | nindent 4 }}
12+
{{- toYaml $svc.annotations | nindent 4 }}
1213
spec:
1314
clusterIP: None
1415
ports:
15-
- port: {{ .Values.service.port }}
16+
- port: {{ $svc.port }}
1617
targetPort: http
1718
protocol: TCP
1819
name: http

charts/trino/values.yaml

Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -486,6 +486,24 @@ shareProcessNamespace:
486486
coordinator: false
487487
worker: false
488488

489+
serviceCoordinator:
490+
annotations: {}
491+
type: ClusterIP
492+
port: 8080
493+
# service.nodePort -- The port the service listens on the host, for the `NodePort` type. If not set, Kubernetes will
494+
# [allocate a port
495+
# automatically](https://kubernetes.io/docs/concepts/services-networking/service/#nodeport-custom-port).
496+
nodePort: ""
497+
498+
serviceWorker:
499+
annotations: {}
500+
type: ClusterIP
501+
port: 8080
502+
# service.nodePort -- The port the service listens on the host, for the `NodePort` type. If not set, Kubernetes will
503+
# [allocate a port
504+
# automatically](https://kubernetes.io/docs/concepts/services-networking/service/#nodeport-custom-port).
505+
nodePort: ""
506+
489507
service:
490508
annotations: {}
491509
type: ClusterIP

tests/trino/test-values.yaml

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -44,6 +44,12 @@ additionalConfigProperties:
4444
- http-server.authentication.allow-insecure-over-http=true
4545
- http-server.process-forwarded=true
4646

47+
48+
serviceCoordinator:
49+
annotations:
50+
custom/coordinator: value
51+
port: 8080
52+
4753
service:
4854
annotations:
4955
custom/name: value

0 commit comments

Comments
 (0)