Skip to content

Commit 65dce0e

Browse files
committed
addressed comments
1 parent 4c8031e commit 65dce0e

File tree

2 files changed

+2
-25
lines changed

2 files changed

+2
-25
lines changed

gateway-ha/src/test/java/io/trino/gateway/ha/persistence/TestJdbcPropertiesProviderFactory.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@
1919
import io.trino.gateway.ha.config.MySqlConfiguration;
2020
import org.junit.jupiter.api.Test;
2121

22+
import java.util.Arrays;
2223
import java.util.List;
2324
import java.util.Properties;
2425

@@ -28,7 +29,7 @@ final class TestJdbcPropertiesProviderFactory
2829
{
2930
private static JdbcPropertiesProviderFactory factoryFor()
3031
{
31-
List<JdbcPropertiesProvider> providers = List.of(
32+
List<JdbcPropertiesProvider> providers = Arrays.asList(
3233
new MySqlJdbcPropertiesProvider(),
3334
new DefaultJdbcPropertiesProvider());
3435
return new JdbcPropertiesProviderFactory(providers);

gateway-ha/src/test/java/io/trino/gateway/ha/router/TestSpecificDbResourceGroupsManager.java

Lines changed: 0 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -13,12 +13,6 @@
1313
*/
1414
package io.trino.gateway.ha.router;
1515

16-
<<<<<<< HEAD
17-
=======
18-
import com.google.inject.AbstractModule;
19-
import com.google.inject.Guice;
20-
import com.google.inject.Injector;
21-
>>>>>>> c13a8db (address comments)
2216
import io.trino.gateway.ha.HaGatewayTestUtils;
2317
import io.trino.gateway.ha.config.DataStoreConfiguration;
2418
import io.trino.gateway.ha.persistence.DefaultJdbcPropertiesProvider;
@@ -54,26 +48,8 @@ void setUp()
5448
HaGatewayTestUtils.seedRequiredData(tempH2DbDir.getAbsolutePath());
5549
DataStoreConfiguration db = new DataStoreConfiguration(jdbcUrl, "sa",
5650
"sa", "org.h2.Driver", 4, false);
57-
<<<<<<< HEAD
5851
Jdbi jdbi = Jdbi.create(jdbcUrl, "sa", "sa");
5952
JdbcConnectionManager connectionManager = new JdbcConnectionManager(jdbi, db, new DefaultJdbcPropertiesProvider());
60-
=======
61-
HaGatewayConfiguration configuration = new HaGatewayConfiguration();
62-
configuration.setDataStore(db);
63-
AbstractModule testConfigModule = new AbstractModule() {
64-
@Override
65-
protected void configure()
66-
{
67-
bind(HaGatewayConfiguration.class)
68-
.toInstance(configuration);
69-
}
70-
};
71-
Injector injector = Guice.createInjector(
72-
testConfigModule,
73-
new RouterBaseModule());
74-
75-
JdbcConnectionManager connectionManager = injector.getInstance(JdbcConnectionManager.class);
76-
>>>>>>> c13a8db (address comments)
7753
super.resourceGroupManager = new HaResourceGroupsManager(connectionManager);
7854
}
7955

0 commit comments

Comments
 (0)