Improve performance when parsing invalid queries

Use BailErrorStrategy as recommended by the ANTLR team.

Author: electrum

core/trino-parser/src/main/java/io/trino/sql/parser/SqlParser.java

@@ -25,6 +25,7 @@
 import io.trino.sql.tree.RowPattern;
 import io.trino.sql.tree.Statement;
 import org.antlr.v4.runtime.ANTLRErrorListener;
+import org.antlr.v4.runtime.BailErrorStrategy;
 import org.antlr.v4.runtime.BaseErrorListener;
 import org.antlr.v4.runtime.CharStreams;
 import org.antlr.v4.runtime.CommonToken;
@@ -39,6 +40,7 @@
 import org.antlr.v4.runtime.atn.PredictionMode;
 import org.antlr.v4.runtime.misc.Interval;
 import org.antlr.v4.runtime.misc.Pair;
+import org.antlr.v4.runtime.misc.ParseCancellationException;
 import org.antlr.v4.runtime.tree.TerminalNode;
 
 import java.util.Arrays;
@@ -144,44 +146,16 @@ private Node invokeParser(String name, String sql, Optional<NodeLocation> locati
             SqlBaseParser parser = new SqlBaseParser(tokenStream);
             initializer.accept(lexer, parser);
 
-            // Override the default error strategy to not attempt inserting or deleting a token.
-            // Otherwise, it messes up error reporting
-            parser.setErrorHandler(new DefaultErrorStrategy()
-            {
-                @Override
-                public Token recoverInline(Parser recognizer)
-                        throws RecognitionException
-                {
-                    if (nextTokensContext == null) {
-                        throw new InputMismatchException(recognizer);
-                    }
-                    throw new InputMismatchException(recognizer, nextTokensState, nextTokensContext);
-                }
-            });
-
             parser.addParseListener(new PostProcessor(Arrays.asList(parser.getRuleNames()), parser));
 
             lexer.removeErrorListeners();
             lexer.addErrorListener(LEXER_ERROR_LISTENER);
 
             parser.removeErrorListeners();
-            parser.addErrorListener(PARSER_ERROR_HANDLER);
 
             ParserRuleContext tree;
             try {
-                try {
-                    // first, try parsing with potentially faster SLL mode
-                    parser.getInterpreter().setPredictionMode(PredictionMode.SLL);
-                    tree = parseFunction.apply(parser);
-                }
-                catch (ParsingException ex) {
-                    // if we fail, parse with LL mode
-                    tokenStream.seek(0); // rewind input stream
-                    parser.reset();
-
-                    parser.getInterpreter().setPredictionMode(PredictionMode.LL);
-                    tree = parseFunction.apply(parser);
-                }
+                tree = twoStageParse(parseFunction, parser);
             }
             catch (ParsingException e) {
                 location.ifPresent(statementLocation -> {
@@ -203,6 +177,39 @@ public Token recoverInline(Parser recognizer)
         }
     }
 
+    private static ParserRuleContext twoStageParse(Function<SqlBaseParser, ParserRuleContext> parseFunction, SqlBaseParser parser)
+    {
+        try {
+            // first, try parsing with potentially faster SLL mode
+            parser.getInterpreter().setPredictionMode(PredictionMode.SLL);
+            parser.setErrorHandler(new BailErrorStrategy());
+            return parseFunction.apply(parser);
+        }
+        catch (ParseCancellationException e) {
+            // if we fail, parse with LL mode
+            parser.reset();
+            parser.getInterpreter().setPredictionMode(PredictionMode.LL);
+            parser.setErrorHandler(new NonRecoveringErrorStrategy());
+            parser.addErrorListener(PARSER_ERROR_HANDLER);
+            return parseFunction.apply(parser);
+        }
+    }
+
+    // Override the default error strategy to not attempt inserting or deleting a token.
+    // Otherwise, it messes up error reporting.
+    private static final class NonRecoveringErrorStrategy
+            extends DefaultErrorStrategy
+    {
+        @Override
+        public Token recoverInline(Parser recognizer)
+        {
+            if (nextTokensContext == null) {
+                throw new InputMismatchException(recognizer);
+            }
+            throw new InputMismatchException(recognizer, nextTokensState, nextTokensContext);
+        }
+    }
+
     private static class PostProcessor
             extends SqlBaseBaseListener
     {