Defunct task.statistics-cpu-timer-enabled flag

CPU time tracking for statistics collection on write has been on by default
for a long time and there is no reason why we would want to disable it

Author: raunaqmorarka

core/trino-main/src/main/java/io/trino/SystemSessionProperties.java

@@ -127,7 +127,6 @@ public final class SystemSessionProperties
     public static final String PREFER_PARTIAL_AGGREGATION = "prefer_partial_aggregation";
     public static final String OPTIMIZE_TOP_N_RANKING = "optimize_top_n_ranking";
     public static final String MAX_GROUPING_SETS = "max_grouping_sets";
-    public static final String STATISTICS_CPU_TIMER_ENABLED = "statistics_cpu_timer_enabled";
     public static final String ENABLE_STATS_CALCULATOR = "enable_stats_calculator";
     public static final String STATISTICS_PRECALCULATION_FOR_PUSHDOWN_ENABLED = "statistics_precalculation_for_pushdown_enabled";
     public static final String COLLECT_PLAN_STATISTICS_FOR_ALL_QUERIES = "collect_plan_statistics_for_all_queries";
@@ -609,11 +608,6 @@ public SystemSessionProperties(
                         "Maximum number of grouping sets in a GROUP BY",
                         featuresConfig.getMaxGroupingSets(),
                         true),
-                booleanProperty(
-                        STATISTICS_CPU_TIMER_ENABLED,
-                        "Experimental: Enable cpu time tracking for automatic column statistics collection on write",
-                        taskManagerConfig.isStatisticsCpuTimerEnabled(),
-                        false),
                 booleanProperty(
                         ENABLE_STATS_CALCULATOR,
                         "Enable statistics calculator",
@@ -1589,11 +1583,6 @@ private static double validateDoubleRange(Object value, String property, double
         return doubleValue;
     }
 
-    public static boolean isStatisticsCpuTimerEnabled(Session session)
-    {
-        return session.getSystemProperty(STATISTICS_CPU_TIMER_ENABLED, Boolean.class);
-    }
-
     public static boolean isEnableStatsCalculator(Session session)
     {
         return session.getSystemProperty(ENABLE_STATS_CALCULATOR, Boolean.class);

core/trino-main/src/main/java/io/trino/execution/TaskManagerConfig.java

@@ -45,6 +45,7 @@
         "task.operator-pre-allocated-memory",
         "task.shard.max-threads",
         "task.verbose-stats",
+        "task.statistics-cpu-timer-enabled",
 })
 public class TaskManagerConfig
 {
@@ -53,7 +54,6 @@ public class TaskManagerConfig
     private boolean threadPerDriverSchedulerEnabled = true;
     private boolean perOperatorCpuTimerEnabled = true;
     private boolean taskCpuTimerEnabled = true;
-    private boolean statisticsCpuTimerEnabled = true;
     private DataSize maxPartialAggregationMemoryUsage = DataSize.of(16, Unit.MEGABYTE);
     private DataSize maxPartialTopNMemory = DataSize.of(16, Unit.MEGABYTE);
     private DataSize maxLocalExchangeBufferSize = DataSize.of(128, Unit.MEGABYTE);
@@ -191,18 +191,6 @@ public TaskManagerConfig setTaskCpuTimerEnabled(boolean taskCpuTimerEnabled)
         return this;
     }
 
-    public boolean isStatisticsCpuTimerEnabled()
-    {
-        return statisticsCpuTimerEnabled;
-    }
-
-    @Config("task.statistics-cpu-timer-enabled")
-    public TaskManagerConfig setStatisticsCpuTimerEnabled(boolean statisticsCpuTimerEnabled)
-    {
-        this.statisticsCpuTimerEnabled = statisticsCpuTimerEnabled;
-        return this;
-    }
-
     @NotNull
     public DataSize getMaxPartialAggregationMemoryUsage()
     {

core/trino-main/src/main/java/io/trino/operator/TableFinishOperator.java

@@ -40,7 +40,6 @@
 
 import static com.google.common.base.Preconditions.checkState;
 import static com.google.common.base.Verify.verify;
-import static io.trino.SystemSessionProperties.isStatisticsCpuTimerEnabled;
 import static io.trino.operator.TableWriterOperator.FRAGMENT_CHANNEL;
 import static io.trino.operator.TableWriterOperator.ROW_COUNT_CHANNEL;
 import static io.trino.spi.type.BigintType.BIGINT;
@@ -92,7 +91,7 @@ public Operator createOperator(DriverContext driverContext)
             checkState(!closed, "Factory is already closed");
             OperatorContext context = driverContext.addOperatorContext(operatorId, planNodeId, TableFinishOperator.class.getSimpleName());
             Operator statisticsAggregationOperator = statisticsAggregationOperatorFactory.createOperator(driverContext);
-            boolean statisticsCpuTimerEnabled = !(statisticsAggregationOperator instanceof DevNullOperator) && isStatisticsCpuTimerEnabled(session);
+            boolean statisticsCpuTimerEnabled = !(statisticsAggregationOperator instanceof DevNullOperator);
             QueryId queryId = driverContext.getPipelineContext().getTaskContext().getQueryContext().getQueryId();
             TableExecuteContext tableExecuteContext = tableExecuteContextManager.getTableExecuteContextForQuery(queryId);
             return new TableFinishOperator(context, tableFinisher, statisticsAggregationOperator, descriptor, statisticsCpuTimerEnabled, tableExecuteContext, outputRowCount);

core/trino-main/src/main/java/io/trino/operator/TableWriterOperator.java

@@ -57,7 +57,6 @@
 import static io.airlift.concurrent.MoreFutures.toListenableFuture;
 import static io.trino.SystemSessionProperties.getCloseIdleWritersTriggerDuration;
 import static io.trino.SystemSessionProperties.getIdleWriterMinDataSizeThreshold;
-import static io.trino.SystemSessionProperties.isStatisticsCpuTimerEnabled;
 import static io.trino.spi.type.BigintType.BIGINT;
 import static io.trino.spi.type.VarbinaryType.VARBINARY;
 import static io.trino.sql.planner.plan.TableWriterNode.CreateTarget;
@@ -122,7 +121,7 @@ public Operator createOperator(DriverContext driverContext)
             }
             OperatorContext context = driverContext.addOperatorContext(operatorId, planNodeId, TableWriterOperator.class.getSimpleName());
             Operator statisticsAggregationOperator = statisticsAggregationOperatorFactory.createOperator(driverContext);
-            boolean statisticsCpuTimerEnabled = !(statisticsAggregationOperator instanceof DevNullOperator) && isStatisticsCpuTimerEnabled(session);
+            boolean statisticsCpuTimerEnabled = !(statisticsAggregationOperator instanceof DevNullOperator);
             return new TableWriterOperator(
                     context,
                     createPageSink(driverContext),

core/trino-main/src/test/java/io/trino/execution/TestTaskManagerConfig.java

@@ -72,7 +72,6 @@ public void testDefaults()
                 .setTaskYieldThreads("3")
                 .setDriverTimeoutThreads("5")
                 .setLevelTimeMultiplier(new BigDecimal("2"))
-                .setStatisticsCpuTimerEnabled(true)
                 .setInterruptStuckSplitTasksEnabled(true)
                 .setInterruptStuckSplitTasksWarningThreshold(new Duration(10, TimeUnit.MINUTES))
                 .setInterruptStuckSplitTasksTimeout(new Duration(15, TimeUnit.MINUTES))
@@ -118,7 +117,6 @@ public void testExplicitPropertyMappings()
                 .put("task.task-yield-threads", "8")
                 .put("task.driver-timeout-threads", "10")
                 .put("task.level-time-multiplier", "2.1")
-                .put("task.statistics-cpu-timer-enabled", "false")
                 .put("task.interrupt-stuck-split-tasks-enabled", "false")
                 .put("task.interrupt-stuck-split-tasks-warning-threshold", "3m")
                 .put("task.interrupt-stuck-split-tasks-timeout", "4m")
@@ -159,7 +157,6 @@ public void testExplicitPropertyMappings()
                 .setTaskYieldThreads("8")
                 .setDriverTimeoutThreads("10")
                 .setLevelTimeMultiplier(new BigDecimal("2.1"))
-                .setStatisticsCpuTimerEnabled(false)
                 .setInterruptStuckSplitTasksEnabled(false)
                 .setInterruptStuckSplitTasksWarningThreshold(new Duration(3, TimeUnit.MINUTES))
                 .setInterruptStuckSplitTasksTimeout(new Duration(4, TimeUnit.MINUTES))