Skip to content

Commit 4a74c68

Browse files
committed
Re-enable running redshift cloud tests
This reverts commit 25304b1.
1 parent 5c4cb0e commit 4a74c68

File tree

1 file changed

+2
-4
lines changed

1 file changed

+2
-4
lines changed

.github/workflows/ci.yml

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -739,12 +739,10 @@ jobs:
739739
REDSHIFT_VPC_SECURITY_GROUP_IDS: ${{ vars.REDSHIFT_VPC_SECURITY_GROUP_IDS }}
740740
REDSHIFT_S3_TPCH_TABLES_ROOT: ${{ vars.REDSHIFT_S3_TPCH_TABLES_ROOT }}
741741
REDSHIFT_S3_UNLOAD_ROOT: ${{ vars.REDSHIFT_S3_UNLOAD_ROOT }}
742-
# TODO: make redshift great again
743742
if: >-
744743
contains(matrix.modules, 'trino-redshift') &&
745744
(contains(matrix.profile, 'cloud-tests') || contains(matrix.profile, 'fte-tests')) &&
746-
(env.CI_SKIP_SECRETS_PRESENCE_CHECKS != '' || env.AWS_ACCESS_KEY_ID != '' || env.REDSHIFT_SUBNET_GROUP_NAME != '') &&
747-
false
745+
(env.CI_SKIP_SECRETS_PRESENCE_CHECKS != '' || env.AWS_ACCESS_KEY_ID != '' || env.REDSHIFT_SUBNET_GROUP_NAME != '')
748746
run: |
749747
source .github/bin/redshift/setup-aws-redshift.sh
750748
@@ -764,7 +762,7 @@ jobs:
764762
AWS_ACCESS_KEY_ID: ${{ vars.REDSHIFT_AWS_ACCESS_KEY_ID }}
765763
AWS_SECRET_ACCESS_KEY: ${{ secrets.REDSHIFT_AWS_SECRET_ACCESS_KEY }}
766764
# Cancelled workflows may have left the ephemeral cluster running
767-
if: false # TODO: make redshift great again
765+
if: always()
768766
run: .github/bin/redshift/delete-aws-redshift.sh
769767
- name: Sanitize artifact name
770768
if: always()

0 commit comments

Comments
 (0)