Skip to content

Commit dfd75cf

Browse files
committed
Rename rollback action consumer to collector
1 parent 45a4c47 commit dfd75cf

File tree

11 files changed

+36
-36
lines changed

11 files changed

+36
-36
lines changed

plugin/trino-base-jdbc/src/main/java/io/trino/plugin/jdbc/BaseJdbcClient.java

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -829,13 +829,13 @@ public void createTable(ConnectorSession session, ConnectorTableMetadata tableMe
829829
}
830830

831831
@Override
832-
public JdbcOutputTableHandle beginCreateTable(ConnectorSession session, ConnectorTableMetadata tableMetadata, Consumer<Runnable> rollbackActionConsumer)
832+
public JdbcOutputTableHandle beginCreateTable(ConnectorSession session, ConnectorTableMetadata tableMetadata, Consumer<Runnable> rollbackActionCollector)
833833
{
834834
try {
835835
if (shouldUseFaultTolerantExecution(session)) {
836836
// Create the target table
837837
JdbcOutputTableHandle destinationTableHandle = createTable(session, tableMetadata, tableMetadata.getTable().getTableName());
838-
rollbackActionConsumer.accept(() -> rollbackCreateDestinationTable(session, destinationTableHandle.getRemoteTableName()));
838+
rollbackActionCollector.accept(() -> rollbackCreateDestinationTable(session, destinationTableHandle.getRemoteTableName()));
839839
// Create the temporary table
840840
ColumnMetadata pageSinkIdColumn = getPageSinkIdColumn(
841841
tableMetadata.getColumns().stream().map(ColumnMetadata::getName).toList());
@@ -1219,7 +1219,7 @@ public JdbcMergeTableHandle beginMerge(
12191219
ConnectorSession session,
12201220
JdbcTableHandle handle,
12211221
Map<Integer, Collection<ColumnHandle>> updateColumnHandles,
1222-
Consumer<Runnable> rollbackActionConsumer,
1222+
Consumer<Runnable> rollbackActionCollector,
12231223
RetryMode retryMode)
12241224
{
12251225
if (!supportsMerge()) {
@@ -1239,14 +1239,14 @@ public JdbcMergeTableHandle beginMerge(
12391239
JdbcTableHandle plainTable = new JdbcTableHandle(schemaTableName, remoteTableName, Optional.empty());
12401240

12411241
JdbcOutputTableHandle outputTableHandle = beginInsertTable(session, plainTable, columns);
1242-
rollbackActionConsumer.accept(() -> rollbackCreateTable(session, outputTableHandle));
1242+
rollbackActionCollector.accept(() -> rollbackCreateTable(session, outputTableHandle));
12431243

12441244
try {
12451245
return new JdbcMergeTableHandle(
12461246
handle,
12471247
outputTableHandle,
1248-
beginUpdate(session, plainTable, columns, primaryKeys, updateColumnHandles, rollbackActionConsumer),
1249-
beginDelete(session, plainTable, primaryKeys, rollbackActionConsumer),
1248+
beginUpdate(session, plainTable, columns, primaryKeys, updateColumnHandles, rollbackActionCollector),
1249+
beginDelete(session, plainTable, primaryKeys, rollbackActionCollector),
12501250
primaryKeys,
12511251
columns,
12521252
updateColumnHandles);
@@ -1262,7 +1262,7 @@ protected Map<Integer, JdbcOutputTableHandle> beginUpdate(
12621262
List<JdbcColumnHandle> columns,
12631263
List<JdbcColumnHandle> primaryKeys,
12641264
Map<Integer, Collection<ColumnHandle>> updateColumnHandles,
1265-
Consumer<Runnable> rollbackActionConsumer)
1265+
Consumer<Runnable> rollbackActionCollector)
12661266
throws SQLException
12671267
{
12681268
if (isNonTransactionalMerge(session)) {
@@ -1301,7 +1301,7 @@ protected Map<Integer, JdbcOutputTableHandle> beginUpdate(
13011301
generateTemporaryTableName(session),
13021302
Optional.of(getPageSinkIdColumn(updatedColumnNames)));
13031303

1304-
rollbackActionConsumer.accept(() -> rollbackCreateTable(session, temporaryTableHandle));
1304+
rollbackActionCollector.accept(() -> rollbackCreateTable(session, temporaryTableHandle));
13051305
outputHandles.put(caseNumber, temporaryTableHandle);
13061306
}
13071307

@@ -1312,14 +1312,14 @@ protected Optional<JdbcOutputTableHandle> beginDelete(
13121312
ConnectorSession session,
13131313
ConnectorTableHandle tableHandle,
13141314
List<JdbcColumnHandle> primaryKeys,
1315-
Consumer<Runnable> rollbackActionConsumer)
1315+
Consumer<Runnable> rollbackActionCollector)
13161316
{
13171317
if (isNonTransactionalMerge(session)) {
13181318
return Optional.empty();
13191319
}
13201320

13211321
JdbcOutputTableHandle handle = beginInsertTable(session, (JdbcTableHandle) tableHandle, primaryKeys);
1322-
rollbackActionConsumer.accept(() -> rollbackCreateTable(session, handle));
1322+
rollbackActionCollector.accept(() -> rollbackCreateTable(session, handle));
13231323
return Optional.of(handle);
13241324
}
13251325

plugin/trino-base-jdbc/src/main/java/io/trino/plugin/jdbc/CachingJdbcClient.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -425,10 +425,10 @@ public JdbcMergeTableHandle beginMerge(
425425
ConnectorSession session,
426426
JdbcTableHandle handle,
427427
Map<Integer, Collection<ColumnHandle>> updateColumnHandles,
428-
Consumer<Runnable> rollbackActionConsumer,
428+
Consumer<Runnable> rollbackActionCollector,
429429
RetryMode retryMode)
430430
{
431-
return delegate.beginMerge(session, handle, updateColumnHandles, rollbackActionConsumer, retryMode);
431+
return delegate.beginMerge(session, handle, updateColumnHandles, rollbackActionCollector, retryMode);
432432
}
433433

434434
@Override
@@ -600,9 +600,9 @@ public void createTable(ConnectorSession session, ConnectorTableMetadata tableMe
600600
}
601601

602602
@Override
603-
public JdbcOutputTableHandle beginCreateTable(ConnectorSession session, ConnectorTableMetadata tableMetadata, Consumer<Runnable> rollbackActionConsumer)
603+
public JdbcOutputTableHandle beginCreateTable(ConnectorSession session, ConnectorTableMetadata tableMetadata, Consumer<Runnable> rollbackActionCollector)
604604
{
605-
return delegate.beginCreateTable(session, tableMetadata, rollbackActionConsumer);
605+
return delegate.beginCreateTable(session, tableMetadata, rollbackActionCollector);
606606
}
607607

608608
@Override

plugin/trino-base-jdbc/src/main/java/io/trino/plugin/jdbc/ForwardingJdbcClient.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -265,9 +265,9 @@ public Optional<PreparedQuery> legacyImplementJoin(
265265
}
266266

267267
@Override
268-
public JdbcOutputTableHandle beginCreateTable(ConnectorSession session, ConnectorTableMetadata tableMetadata, Consumer<Runnable> rollbackActionConsumer)
268+
public JdbcOutputTableHandle beginCreateTable(ConnectorSession session, ConnectorTableMetadata tableMetadata, Consumer<Runnable> rollbackActionCollector)
269269
{
270-
return delegate().beginCreateTable(session, tableMetadata, rollbackActionConsumer);
270+
return delegate().beginCreateTable(session, tableMetadata, rollbackActionCollector);
271271
}
272272

273273
@Override
@@ -293,10 +293,10 @@ public JdbcMergeTableHandle beginMerge(
293293
ConnectorSession session,
294294
JdbcTableHandle handle,
295295
Map<Integer, Collection<ColumnHandle>> updateColumnHandles,
296-
Consumer<Runnable> rollbackActionConsumer,
296+
Consumer<Runnable> rollbackActionCollector,
297297
RetryMode retryMode)
298298
{
299-
return delegate().beginMerge(session, handle, updateColumnHandles, rollbackActionConsumer, retryMode);
299+
return delegate().beginMerge(session, handle, updateColumnHandles, rollbackActionCollector, retryMode);
300300
}
301301

302302
@Override

plugin/trino-base-jdbc/src/main/java/io/trino/plugin/jdbc/JdbcClient.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -210,7 +210,7 @@ default void setTableProperties(ConnectorSession session, JdbcTableHandle handle
210210

211211
void createTable(ConnectorSession session, ConnectorTableMetadata tableMetadata);
212212

213-
JdbcOutputTableHandle beginCreateTable(ConnectorSession session, ConnectorTableMetadata tableMetadata, Consumer<Runnable> rollbackActionConsumer);
213+
JdbcOutputTableHandle beginCreateTable(ConnectorSession session, ConnectorTableMetadata tableMetadata, Consumer<Runnable> rollbackActionCollector);
214214

215215
void commitCreateTable(ConnectorSession session, JdbcOutputTableHandle handle, Set<Long> pageSinkIds);
216216

@@ -222,7 +222,7 @@ default JdbcMergeTableHandle beginMerge(
222222
ConnectorSession session,
223223
JdbcTableHandle handle,
224224
Map<Integer, Collection<ColumnHandle>> updateColumnHandles,
225-
Consumer<Runnable> rollbackActionConsumer,
225+
Consumer<Runnable> rollbackActionCollector,
226226
RetryMode retryMode)
227227
{
228228
throw new TrinoException(NOT_SUPPORTED, MODIFYING_ROWS_MESSAGE);

plugin/trino-base-jdbc/src/main/java/io/trino/plugin/jdbc/RetryingJdbcClient.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -368,10 +368,10 @@ public void createTable(ConnectorSession session, ConnectorTableMetadata tableMe
368368
}
369369

370370
@Override
371-
public JdbcOutputTableHandle beginCreateTable(ConnectorSession session, ConnectorTableMetadata tableMetadata, Consumer<Runnable> rollbackActionConsumer)
371+
public JdbcOutputTableHandle beginCreateTable(ConnectorSession session, ConnectorTableMetadata tableMetadata, Consumer<Runnable> rollbackActionCollector)
372372
{
373373
// no retrying as it could be not idempotent operation
374-
return delegate.beginCreateTable(session, tableMetadata, rollbackActionConsumer);
374+
return delegate.beginCreateTable(session, tableMetadata, rollbackActionCollector);
375375
}
376376

377377
@Override
@@ -400,11 +400,11 @@ public JdbcMergeTableHandle beginMerge(
400400
ConnectorSession session,
401401
JdbcTableHandle handle,
402402
Map<Integer, Collection<ColumnHandle>> updateColumnHandles,
403-
Consumer<Runnable> rollbackActionConsumer,
403+
Consumer<Runnable> rollbackActionCollector,
404404
RetryMode retryMode)
405405
{
406406
// no retrying as it could be not idempotent operation
407-
return delegate.beginMerge(session, handle, updateColumnHandles, rollbackActionConsumer, retryMode);
407+
return delegate.beginMerge(session, handle, updateColumnHandles, rollbackActionCollector, retryMode);
408408
}
409409

410410
@Override

plugin/trino-base-jdbc/src/main/java/io/trino/plugin/jdbc/jmx/StatisticsAwareJdbcClient.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -353,9 +353,9 @@ public void createTable(ConnectorSession session, ConnectorTableMetadata tableMe
353353
}
354354

355355
@Override
356-
public JdbcOutputTableHandle beginCreateTable(ConnectorSession session, ConnectorTableMetadata tableMetadata, Consumer<Runnable> rollbackActionConsumer)
356+
public JdbcOutputTableHandle beginCreateTable(ConnectorSession session, ConnectorTableMetadata tableMetadata, Consumer<Runnable> rollbackActionCollector)
357357
{
358-
return stats.getBeginCreateTable().wrap(() -> delegate().beginCreateTable(session, tableMetadata, rollbackActionConsumer));
358+
return stats.getBeginCreateTable().wrap(() -> delegate().beginCreateTable(session, tableMetadata, rollbackActionCollector));
359359
}
360360

361361
@Override
@@ -381,10 +381,10 @@ public JdbcMergeTableHandle beginMerge(
381381
ConnectorSession session,
382382
JdbcTableHandle handle,
383383
Map<Integer, Collection<ColumnHandle>> updateColumnHandles,
384-
Consumer<Runnable> rollbackActionConsumer,
384+
Consumer<Runnable> rollbackActionCollector,
385385
RetryMode retryMode)
386386
{
387-
return stats.getBeginMergeTable().wrap(() -> delegate().beginMerge(session, handle, updateColumnHandles, rollbackActionConsumer, retryMode));
387+
return stats.getBeginMergeTable().wrap(() -> delegate().beginMerge(session, handle, updateColumnHandles, rollbackActionCollector, retryMode));
388388
}
389389

390390
@Override

plugin/trino-druid/src/main/java/io/trino/plugin/druid/DruidJdbcClient.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -477,7 +477,7 @@ public void createTable(ConnectorSession session, ConnectorTableMetadata tableMe
477477
}
478478

479479
@Override
480-
public JdbcOutputTableHandle beginCreateTable(ConnectorSession session, ConnectorTableMetadata tableMetadata, Consumer<Runnable> rollbackActionConsumer)
480+
public JdbcOutputTableHandle beginCreateTable(ConnectorSession session, ConnectorTableMetadata tableMetadata, Consumer<Runnable> rollbackActionCollector)
481481
{
482482
throw new TrinoException(NOT_SUPPORTED, "This connector does not support creating tables with data");
483483
}

plugin/trino-exasol/src/main/java/io/trino/plugin/exasol/ExasolClient.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -315,7 +315,7 @@ public WriteMapping toWriteMapping(ConnectorSession session, Type type)
315315
}
316316

317317
@Override
318-
public JdbcOutputTableHandle beginCreateTable(ConnectorSession session, ConnectorTableMetadata tableMetadata, Consumer<Runnable> rollbackActionConsumer)
318+
public JdbcOutputTableHandle beginCreateTable(ConnectorSession session, ConnectorTableMetadata tableMetadata, Consumer<Runnable> rollbackActionCollector)
319319
{
320320
throw new TrinoException(NOT_SUPPORTED, "This connector does not support creating tables with data");
321321
}

plugin/trino-ignite/src/main/java/io/trino/plugin/ignite/IgniteClient.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -382,7 +382,7 @@ private static void checkDateValue(long epochDay)
382382
}
383383

384384
@Override
385-
public JdbcOutputTableHandle beginCreateTable(ConnectorSession session, ConnectorTableMetadata tableMetadata, Consumer<Runnable> rollbackActionConsumer)
385+
public JdbcOutputTableHandle beginCreateTable(ConnectorSession session, ConnectorTableMetadata tableMetadata, Consumer<Runnable> rollbackActionCollector)
386386
{
387387
if (tableMetadata.getComment().isPresent()) {
388388
throw new TrinoException(NOT_SUPPORTED, "This connector does not support creating tables with table comment");
@@ -424,7 +424,7 @@ public JdbcOutputTableHandle beginCreateTable(ConnectorSession session, Connecto
424424
columnTypes.build(),
425425
Optional.empty(),
426426
primaryKeys.isEmpty() ? Optional.of(IGNITE_DUMMY_ID) : Optional.empty());
427-
rollbackActionConsumer.accept(() -> rollbackCreateDestinationTable(session, destinationTableHandle.getRemoteTableName()));
427+
rollbackActionCollector.accept(() -> rollbackCreateDestinationTable(session, destinationTableHandle.getRemoteTableName()));
428428
return destinationTableHandle;
429429
}
430430
catch (SQLException e) {

plugin/trino-mysql/src/main/java/io/trino/plugin/mysql/MySqlClient.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1076,7 +1076,7 @@ public JdbcMergeTableHandle beginMerge(
10761076
ConnectorSession session,
10771077
JdbcTableHandle handle,
10781078
Map<Integer, Collection<ColumnHandle>> updateColumnHandles,
1079-
Consumer<Runnable> rollbackActionConsumer,
1079+
Consumer<Runnable> rollbackActionCollector,
10801080
RetryMode retryMode)
10811081
{
10821082
if (retryMode != NO_RETRIES) {
@@ -1087,7 +1087,7 @@ public JdbcMergeTableHandle beginMerge(
10871087
throw new TrinoException(NOT_SUPPORTED, "This connector does not support MERGE with transactional execution");
10881088
}
10891089

1090-
return super.beginMerge(session, handle, updateColumnHandles, rollbackActionConsumer, retryMode);
1090+
return super.beginMerge(session, handle, updateColumnHandles, rollbackActionCollector, retryMode);
10911091
}
10921092

10931093
@Override

0 commit comments

Comments
 (0)