Skip to content

Commit e6c6239

Browse files
committed
Skip verify method in BigQuery smoke test
1 parent 062dc3a commit e6c6239

File tree

2 files changed

+26
-1
lines changed

2 files changed

+26
-1
lines changed

plugin/trino-bigquery/src/main/java/io/trino/plugin/bigquery/BigQueryMetadata.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -841,7 +841,7 @@ public void createMaterializedView(
841841
boolean replace,
842842
boolean ignoreExisting)
843843
{
844-
// TODO Fix BaseBigQueryFailureRecoveryTest when implementing this method
844+
// TODO Fix BaseBigQueryFailureRecoveryTest and TestBigQueryWithDifferentProjectIdConnectorSmokeTest when implementing this method
845845
ConnectorMetadata.super.createMaterializedView(session, viewName, definition, properties, replace, ignoreExisting);
846846
}
847847

plugin/trino-bigquery/src/test/java/io/trino/plugin/bigquery/TestBigQueryWithDifferentProjectIdConnectorSmokeTest.java

Lines changed: 25 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@
2424
import static io.trino.testing.TestingNames.randomNameSuffix;
2525
import static io.trino.testing.TestingProperties.requiredNonEmptySystemProperty;
2626
import static org.assertj.core.api.Assertions.assertThat;
27+
import static org.junit.jupiter.api.Assumptions.abort;
2728

2829
public class TestBigQueryWithDifferentProjectIdConnectorSmokeTest
2930
extends BaseConnectorSmokeTest
@@ -62,6 +63,30 @@ protected boolean hasBehavior(TestingConnectorBehavior connectorBehavior)
6263
};
6364
}
6465

66+
@Test
67+
@Override
68+
public void verifySupportsRowLevelDeleteDeclaration()
69+
{
70+
// This connector does not support modifying table rows
71+
abort("skipped");
72+
}
73+
74+
@Test
75+
@Override
76+
public void verifySupportsUpdateDeclaration()
77+
{
78+
// This connector does not support modifying table rows
79+
abort("skipped");
80+
}
81+
82+
@Test
83+
@Override
84+
public void verifySupportsRowLevelUpdateDeclaration()
85+
{
86+
// This connector does not support modifying table rows
87+
abort("skipped");
88+
}
89+
6590
@Test
6691
public void testCreateSchemasInDifferentProjectIdCatalog()
6792
{

0 commit comments

Comments
 (0)