Disable INTERN_FIELD_NAMES to reduce contention during json serde#28461
Merged
Disable INTERN_FIELD_NAMES to reduce contention during json serde#28461
Conversation
d13666b to
d895977
Compare
losipiuk
approved these changes
Feb 25, 2026
| * impact - field name deduplication becomes slightly less memory-efficient, but the | ||
| * elimination of lock contention far outweighs this cost in high-concurrency scenarios. | ||
| * | ||
| * @see <a href="https://github.com/FasterXML/jackson-core/issues/332">Jackson issue on InternCache contention</a> |
Member
There was a problem hiding this comment.
Is this something to revisit in the future given this is seen as a bug in Jackson?
Contributor
Author
There was a problem hiding this comment.
Once we switch to Jackson 3.0 it won't be needed:
And for TL;DNR observers, Jackson 3.0 DOES NOT use String.intern() by default,
and the implementation is such that it typically performs at same level with or without intern()ing, including usage through databinding.
Member
|
if we change airlift default why also change in trino? |
findepi
reviewed
Mar 2, 2026
| * impact - field name deduplication becomes slightly less memory-efficient, but the | ||
| * elimination of lock contention far outweighs this cost in high-concurrency scenarios. | ||
| * | ||
| * @see <a href="https://github.com/FasterXML/jackson-core/issues/332">Jackson issue on InternCache contention</a> |
Member
There was a problem hiding this comment.
It's not a javadoc. Why use javadoc markup?
findepi
reviewed
Mar 2, 2026
| * impact - field name deduplication becomes slightly less memory-efficient, but the | ||
| * elimination of lock contention far outweighs this cost in high-concurrency scenarios. | ||
| * | ||
| * @see <a href="https://github.com/FasterXML/jackson-core/issues/332">Jackson issue on InternCache contention</a> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
airlift/airlift#1793
Additional context and related issues
Release notes
(x) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text: