Add missing BigQuery connector configuration properties to documentation#28496
Add missing BigQuery connector configuration properties to documentation#28496shunki-fujita wants to merge 1 commit intotrinodb:masterfrom
Conversation
Signed-off-by: shunki-fujita <shunki-fujita@cybozu.co.jp>
|
Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla |
|
@shunki-fujita Have you already submitted the CLA? |
There was a problem hiding this comment.
Pull request overview
This PR adds documentation for five previously undocumented BigQuery connector configuration properties that were already implemented in the code but missing from the configuration properties table, as identified in issue #28495.
Changes:
- Documents
bigquery.metadata.parallelismandbigquery.metadata-page-sizein the metadata section of the configuration table - Documents
bigquery.job.label-nameandbigquery.job.label-formatafter the query results cache entry - Documents
bigquery.projection-pushdown-enabledbeforebigquery.max-parallelism
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| - | ||
| * - `bigquery.job.label-format` | ||
| - Value format for the label specified by `bigquery.job.label-name`. May | ||
| consist of letters, digits, underscores, commas, spaces, equal signs, and |
There was a problem hiding this comment.
The documentation for bigquery.job.label-format states that the value may consist of "letters, digits, underscores, commas, spaces, equal signs, and predefined values", but the actual validation regex in FormatInterpolator.java (line 64) is [\\w ,_\\-=], which also allows hyphens (-). The hyphen character is missing from the documentation's list of allowed characters.
| consist of letters, digits, underscores, commas, spaces, equal signs, and | |
| consist of letters, digits, underscores, hyphens, commas, spaces, equal signs, and |
Description
Close: #28495
Several BigQuery connector configuration properties are defined in the code but missing from the documentation
Release notes
(x) This is not user-visible or is docs only, and no release notes are required.