Skip to content

Add missing BigQuery connector configuration properties to documentation#28496

Open
shunki-fujita wants to merge 1 commit intotrinodb:masterfrom
shunki-fujita:doc/add-missing-bigquery-properties
Open

Add missing BigQuery connector configuration properties to documentation#28496
shunki-fujita wants to merge 1 commit intotrinodb:masterfrom
shunki-fujita:doc/add-missing-bigquery-properties

Conversation

@shunki-fujita
Copy link

@shunki-fujita shunki-fujita commented Mar 2, 2026

Description

Close: #28495
Several BigQuery connector configuration properties are defined in the code but missing from the documentation

Release notes

(x) This is not user-visible or is docs only, and no release notes are required.

Signed-off-by: shunki-fujita <shunki-fujita@cybozu.co.jp>
@cla-bot
Copy link

cla-bot bot commented Mar 2, 2026

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

@github-actions github-actions bot added the docs label Mar 2, 2026
@ebyhr ebyhr requested a review from Copilot March 2, 2026 09:20
@ebyhr
Copy link
Member

ebyhr commented Mar 2, 2026

@shunki-fujita Have you already submitted the CLA?

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds documentation for five previously undocumented BigQuery connector configuration properties that were already implemented in the code but missing from the configuration properties table, as identified in issue #28495.

Changes:

  • Documents bigquery.metadata.parallelism and bigquery.metadata-page-size in the metadata section of the configuration table
  • Documents bigquery.job.label-name and bigquery.job.label-format after the query results cache entry
  • Documents bigquery.projection-pushdown-enabled before bigquery.max-parallelism

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

-
* - `bigquery.job.label-format`
- Value format for the label specified by `bigquery.job.label-name`. May
consist of letters, digits, underscores, commas, spaces, equal signs, and
Copy link

Copilot AI Mar 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The documentation for bigquery.job.label-format states that the value may consist of "letters, digits, underscores, commas, spaces, equal signs, and predefined values", but the actual validation regex in FormatInterpolator.java (line 64) is [\\w ,_\\-=], which also allows hyphens (-). The hyphen character is missing from the documentation's list of allowed characters.

Suggested change
consist of letters, digits, underscores, commas, spaces, equal signs, and
consist of letters, digits, underscores, hyphens, commas, spaces, equal signs, and

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

Add missing BigQuery connector configuration properties to documentation

3 participants