Remove special casing for explicit row in VALUES #27463
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wendigo
approved these changes
Nov 26, 2025
kasiafi
approved these changes
Nov 27, 2025
| } | ||
|
|
||
| Type targetType = commonSuperType; | ||
| if (!(actualType instanceof RowType)) { |
Member
There was a problem hiding this comment.
Please retain the comment explaining why we have to unpack the supertype in this case.
Member
findepi
added
the
no-release-notes
martint
force-pushed
the
values-coercion
branch
2 times, most recently
from
497bb25 to
e131ecc
Compare
wendigo
reviewed
Dec 2, 2025
| for (int field = 0; field < type.getFields().size(); field++) { | ||
| Type fieldType = type.getFields().get(field).getType(); | ||
|
|
||
| SqlRow rowValue = (SqlRow) row.value(); |
Contributor
There was a problem hiding this comment.
Can this be moved outside of the loop?
wendigo
reviewed
Dec 2, 2025
| for (int field = 0; field < type.getFields().size(); field++) { | ||
| Type fieldType = type.getFields().get(field).getType(); | ||
|
|
||
| SqlRow rowValue = (SqlRow) row.value(); |
Injecting coerciones field by field is no longer needed. This is now handled by PushCastIntoRow.
martint
force-pushed
the
values-coercion
branch
from
e131ecc to
bd21493
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Injecting coerciones field by field is no longer needed. This is now handled by PushCastIntoRow.
Release notes
(x) This is not user-visible or is docs only, and no release notes are required.