Improve performance when parsing invalid queries #27513
Conversation
Use BailErrorStrategy as recommended by the ANTLR team.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
martint
left a comment
martint
left a comment
There was a problem hiding this comment.
Do you have any (micro-)benchmark results for this change?
| catch (ParsingException ex) { | ||
| catch (ParseCancellationException e) { | ||
| // if we fail, parse with LL mode | ||
| tokenStream.seek(0); // rewind input stream |
There was a problem hiding this comment.
The Parser.reset() method already does this
|
This is more about doing it in the correct way, that could theoretically improve performance. I don't actually care about the performance and didn't bother to benchmark it. This could alternatively be titled
|
2 participants
Use
BailErrorStrategyas recommended by the ANTLR team in antlr/antlr4#192Release notes
(x) This is not user-visible or is docs only, and no release notes are required.