Skip to content

[Exasol] Re-enable Exasol testsuite, update Exasol testcontainers #27518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
+7 −5
Open

[Exasol] Re-enable Exasol testsuite, update Exasol testcontainers #27518

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
696c93e
update containers, disable rsyslogd
pj-spoelders Nov 27, 2025
4184727
Uncomment exasol suite in CI tests file
pj-spoelders Nov 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -912,7 +912,7 @@ jobs:
- suite-delta-lake-databricks154
- suite-delta-lake-databricks164
- suite-delta-lake-databricks173
#- suite-exasol
- suite-exasol
Copy link
Member

@findepi findepi Dec 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you

- suite-ranger
- suite-gcs
- suite-hive4
Expand Down
5 changes: 3 additions & 2 deletions plugin/trino-exasol/src/test/java/io/trino/plugin/exasol/TestingExasolServer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,9 +47,10 @@ public class TestingExasolServer

public TestingExasolServer()
{
container = new ExasolContainer<>("8.34.0")
container = new ExasolContainer<>("2025.1.3")
.withExposedPorts(8563)
.withRequiredServices(ExasolService.JDBC);
.withRequiredServices(ExasolService.JDBC)
.withEnv("COSLWD_ENABLED", "1");
Copy link
Member

@findepi findepi Dec 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add a code comment what COSLWD_ENABLED=1 is for

Copy link
Member

@findepi findepi Dec 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also, in update containers, disable rsyslogd commit
can you maybe change title to sth like Update Exasol container [...]

cleanup = startOrReuse(container);
executeAsSys(format("CREATE USER %s IDENTIFIED BY \"%s\"", TEST_USER, TEST_PASSWORD));
executeAsSys("GRANT CREATE SESSION TO " + TEST_USER);
Expand Down
5 changes: 3 additions & 2 deletions ...her/src/main/java/io/trino/tests/product/launcher/env/environment/EnvMultinodeExasol.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,9 +56,10 @@ public void extendEnvironment(Builder builder)

private DockerContainer createExasol()
{
DockerContainer container = new DockerContainer("exasol/docker-db:8.34.0", "exasol")
DockerContainer container = new DockerContainer("exasol/docker-db:2025.1.3", "exasol")
.withStartupCheckStrategy(new IsRunningStartupCheckStrategy())
.waitingFor(forSelectedPorts(EXASOL_PORT));
.waitingFor(forSelectedPorts(EXASOL_PORT))
.withEnv("COSLWD_ENABLED", "1");
container.setPrivilegedMode(true);
portBinder.exposePort(container, EXASOL_PORT);
return container;
Expand Down
Loading