Have the board refresh when new techs are discovered. #14023
jonoruss2
started this conversation in
Feature Requests & Ideas
Replies: 2 comments 1 reply
-
|
I do not see any PR from you @jonoruss2 |
Beta Was this translation helpful? Give feedback.
1 reply
-
|
How do you try to create the PR, @jonoruss2? |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
-
One thing I've noticed when playing (a lot) of this game, is that when I get a new technology, the board doesn't update the game icons. So if I roll and get "Industrial Tech", the factories all look the same, unless I reload the board by saving/reloading or increase/decrease the icon sizes. This is fine but also kinda annoying after awhile.
This can be fixed (and I've verified this), with a single line of code in game-app/game-headed/src/main/java/games/strategy/triplea/ui/TripleAFrame.java :
this.mapPanel.resetMap();
on line 912.
It's possible that a better option might be to put this one line in with the lambda expression above it, in the ifPresent area.
I've been playing it with this change for awhile, and it works great. It passes all the tests, and passes formatting validation.
I tried doing a pull request, but it says I'm not a "contributor". I'm not sure how I become one, and, honestly, this is a lot of paperwork for a single line of code.
So instead, I'm just going to drop it in the feature requests/ideas box.
Beta Was this translation helpful? Give feedback.
All reactions