Skip to content

Commit a0f8ad6

Browse files
committed
Revert to windows-wheel and moved GPU override
1 parent ec2e9c2 commit a0f8ad6

File tree

4 files changed

+11
-15
lines changed

4 files changed

+11
-15
lines changed

CMakeLists.txt

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -64,13 +64,6 @@ if(NOT TRITON_ENABLE_PYTHON_GRPC)
6464
set(TRITON_COMMON_ENABLE_PROTOBUF_PYTHON OFF)
6565
endif()
6666

67-
# FIXME: Windows client currently does not support GPU tensors.
68-
# For simplicity, we will override this option here.
69-
if(WIN32 AND TRITON_ENABLE_GPU)
70-
message("GPU shared memory is not currently supported by the Windows client. Forcing TRITON_ENABLE_GPU to false.")
71-
set(TRITON_ENABLE_GPU OFF CACHE BOOL "GPU disabled" FORCE)
72-
endif()
73-
7467
#
7568
# Dependencies
7669
#

src/python/CMakeLists.txt

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -45,6 +45,13 @@ if(NOT CMAKE_BUILD_TYPE)
4545
set(CMAKE_BUILD_TYPE Release)
4646
endif()
4747

48+
# FIXME: Windows client currently does not support GPU tensors.
49+
# For simplicity, we will override this option here.
50+
if(WIN32 AND TRITON_ENABLE_GPU)
51+
message("GPU shared memory is not currently supported by the Windows python client. Forcing TRITON_ENABLE_GPU to false.")
52+
set(TRITON_ENABLE_GPU OFF CACHE BOOL "GPU disabled" FORCE)
53+
endif()
54+
4855
#
4956
# Dependencies
5057
#

src/python/library/build_wheel.py

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -230,10 +230,9 @@ def sed(pattern, replace, source, dest=None):
230230
else:
231231
platform_name = "manylinux1_x86_64"
232232
args = ["python3", "setup.py", "bdist_wheel", "--plat-name", platform_name]
233-
# FIXME: Uncomment when Windows tests do not use WSL
234-
# elif FLAGS.windows and platform.uname().machine == "AMD64":
235-
# platform_name = "win_amd64"
236-
# args = ["python3", "setup.py", "bdist_wheel", "--plat-name", platform_name]
233+
elif FLAGS.windows and platform.uname().machine == "AMD64":
234+
platform_name = "win_amd64"
235+
args = ["python3", "setup.py", "bdist_wheel", "--plat-name", platform_name]
237236
else:
238237
args = ["python3", "setup.py", "bdist_wheel"]
239238

src/python/library/setup.py

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -78,10 +78,7 @@ def req_file(filename, folder="requirements"):
7878
platform_package_data = []
7979
if "linux" in PLATFORM_FLAG:
8080
platform_package_data += ["libcshm.so"]
81-
# FIXME: Uncomment when Windows tests do not use WSL
82-
# elif PLATFORM_FLAG == "win_amd64":
83-
# platform_package_data += ["cshm.dll"]
84-
else:
81+
elif PLATFORM_FLAG == "win_amd64":
8582
platform_package_data += ["cshm.dll"]
8683

8784
data_files = [

0 commit comments

Comments
 (0)