Skip to content

Commit bfde737

Browse files
committed
updating tests
1 parent 91bceb8 commit bfde737

File tree

4 files changed

+6
-9
lines changed

4 files changed

+6
-9
lines changed

src/c++/perf_analyzer/genai-perf/genai_perf/llm_inputs/llm_inputs.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -225,7 +225,6 @@ def _get_input_dataset_from_url(
225225
url = cls._resolve_url(dataset_name)
226226
configured_url = cls._create_configured_url(url, starting_index, length)
227227
dataset = cls._download_dataset(configured_url)
228-
229228
return dataset
230229

231230
@classmethod

src/c++/perf_analyzer/genai-perf/genai_perf/parser.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -119,7 +119,7 @@ def _check_conditional_args(
119119
if args.service_kind != "triton":
120120
if args.output_tokens_mean_deterministic:
121121
parser.error(
122-
"The --output-tokens-mean-deterministic option is only supported with the Triton service-kind."
122+
"The --output-tokens-mean-deterministic option is only supported with the kserve endpoint type."
123123
)
124124

125125
return args
@@ -252,7 +252,7 @@ def _add_input_args(parser):
252252
help=f"When using --output-tokens-mean, this flag can be set to "
253253
"improve precision by setting the minimum number of tokens "
254254
"equal to the requested number of tokens. This is currently "
255-
"supported with the Triton service-kind. "
255+
"supported with the kserve endpoint type. "
256256
"Note that there is still some variability in the requested number "
257257
"of output tokens, but GenAi-Perf attempts its best effort with your "
258258
"model to get the right number of output tokens. ",

src/c++/perf_analyzer/genai-perf/tests/test_cli.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -376,7 +376,7 @@ def test_unrecognized_arg(self, monkeypatch, capsys):
376376
"100",
377377
"--output-tokens-mean-deterministic",
378378
],
379-
"The --output-tokens-mean-deterministic option is only supported with the Triton service-kind",
379+
"The --output-tokens-mean-deterministic option is only supported with the kserve endpoint type",
380380
),
381381
],
382382
)

src/c++/perf_analyzer/genai-perf/tests/test_wrapper.py

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ class TestWrapper:
4343
],
4444
)
4545
def test_url_exactly_once_triton(self, monkeypatch, arg):
46-
args = ["genai-perf", "-m", "test_model", "--service-kind", "triton"] + arg
46+
args = ["genai-perf", "-m", "test_model", "--endpoint-type", "kserve"] + arg
4747
monkeypatch.setattr("sys.argv", args)
4848
args, extra_args = parser.parse_args()
4949
cmd = Profiler.build_cmd(args, extra_args)
@@ -70,7 +70,7 @@ def test_url_exactly_once_triton(self, monkeypatch, arg):
7070
],
7171
)
7272
def test_profile_export_filepath(self, monkeypatch, arg, expected_filepath):
73-
args = ["genai-perf", "-m", "test_model", "--service-kind", "triton"] + arg
73+
args = ["genai-perf", "-m", "test_model", "--endpoint-type", "kserve"] + arg
7474
monkeypatch.setattr("sys.argv", args)
7575
args, extra_args = parser.parse_args()
7676
cmd = Profiler.build_cmd(args, extra_args)
@@ -87,7 +87,7 @@ def test_profile_export_filepath(self, monkeypatch, arg, expected_filepath):
8787
],
8888
)
8989
def test_service_triton(self, monkeypatch, arg):
90-
args = ["genai-perf", "-m", "test_model", "--service-kind", "triton"] + arg
90+
args = ["genai-perf", "-m", "test_model", "--endpoint-type", "kserve"] + arg
9191
monkeypatch.setattr("sys.argv", args)
9292
args, extra_args = parser.parse_args()
9393
cmd = Profiler.build_cmd(args, extra_args)
@@ -113,8 +113,6 @@ def test_service_openai(self, monkeypatch, arg):
113113
"genai-perf",
114114
"-m",
115115
"test_model",
116-
"--service-kind",
117-
"openai",
118116
] + arg
119117
monkeypatch.setattr("sys.argv", args)
120118
args, extra_args = parser.parse_args()

0 commit comments

Comments
 (0)