Fix linter issues in GenAi-Perf (#573)

Author: the-david-oy

.pre-commit-config.yaml

@@ -72,3 +72,13 @@ repos:
   - id: mixed-line-ending
   - id: requirements-txt-fixer
   - id: trailing-whitespace
+
+- repo: https://github.com/pre-commit/mirrors-mypy
+  rev: v1.9.0
+  hooks:
+  - id: mypy
+    types_or: [python, cython]
+    additional_dependencies: [tokenize-rt==3.2.0, types-requests]
+    exclude: >-
+      (?x)
+      ^(?!(src/c\+\+/perf_analyzer/genai-perf/)).*\.py$

src/c++/perf_analyzer/genai-perf/genai_perf/graphs/base_plot.py

@@ -63,12 +63,12 @@ def create_plot(
         """
         raise NotImplementedError
 
-    def _generate_parquet(self, dataframe: DataFrame, file: str):
+    def _generate_parquet(self, dataframe: DataFrame, file: str) -> None:
         dataframe.to_parquet(
             f"{DEFAULT_ARTIFACT_DIR}/data/{file}.gzip", compression="gzip"
         )
 
-    def _generate_graph_file(self, fig: Figure, file: str, title: str):
+    def _generate_graph_file(self, fig: Figure, file: str, title: str) -> None:
         if file.endswith("jpeg"):
             print(f"Generating '{title}' jpeg")
             fig.write_image(f"{DEFAULT_ARTIFACT_DIR}/images/{file}")

src/c++/perf_analyzer/genai-perf/genai_perf/graphs/box_plot.py

@@ -55,7 +55,7 @@ def create_plot(
         x_label: str = "",
         y_label: str = "",
         filename_root: str = "",
-    ):
+    ) -> None:
         df = pd.DataFrame({y_metric: self._metrics_data[y_key]})
         fig = px.box(
             df,

src/c++/perf_analyzer/genai-perf/genai_perf/graphs/heat_map.py

@@ -25,7 +25,7 @@
 # (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
 # OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 
-from typing import Dict
+from typing import Dict, Optional
 
 import pandas as pd
 import plotly.express as px
@@ -38,7 +38,7 @@ class HeatMap(BasePlot):
     Generate a heat map in jpeg and html format.
     """
 
-    def __init__(self, stats: Statistics, extra_data: Dict | None = None) -> None:
+    def __init__(self, stats: Statistics, extra_data: Optional[Dict] = None) -> None:
         super().__init__(stats, extra_data)
 
     def create_plot(
@@ -51,7 +51,7 @@ def create_plot(
         x_label: str = "",
         y_label: str = "",
         filename_root: str = "",
-    ):
+    ) -> None:
         x_values = self._metrics_data[x_key]
         y_values = self._metrics_data[y_key]
         df = pd.DataFrame(

src/c++/perf_analyzer/genai-perf/genai_perf/graphs/scatter_plot.py

@@ -25,7 +25,7 @@
 # (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
 # OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 
-from typing import Dict
+from typing import Dict, Optional
 
 import pandas as pd
 import plotly.express as px
@@ -38,7 +38,7 @@ class ScatterPlot(BasePlot):
     Generate a scatter plot in jpeg and html format.
     """
 
-    def __init__(self, stats: Statistics, extra_data: Dict | None = None) -> None:
+    def __init__(self, stats: Statistics, extra_data: Optional[Dict] = None) -> None:
         super().__init__(stats, extra_data)
 
     def create_plot(
@@ -51,7 +51,7 @@ def create_plot(
         x_label: str = "",
         y_label: str = "",
         filename_root: str = "",
-    ):
+    ) -> None:
         x_values = self._metrics_data[x_key]
         y_values = self._metrics_data[y_key]