Skip to content

Commit e827f28

Browse files
authored
Extend Common Compile Settings to Protobuf (#123)
Extend Common Compile Settings to Protobuf
1 parent 4be655b commit e827f28

File tree

1 file changed

+12
-15
lines changed

1 file changed

+12
-15
lines changed

protobuf/CMakeLists.txt

Lines changed: 12 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -63,11 +63,10 @@ if(${TRITON_COMMON_ENABLE_PROTOBUF})
6363
$<BUILD_INTERFACE:${CMAKE_CURRENT_BINARY_DIR}>
6464
)
6565

66-
target_compile_options(
67-
proto-library PRIVATE
68-
$<$<OR:$<CXX_COMPILER_ID:Clang>,$<CXX_COMPILER_ID:AppleClang>,$<CXX_COMPILER_ID:GNU>>:
69-
-Wall -Wextra -Wno-unused-parameter -Werror>
70-
$<$<CXX_COMPILER_ID:MSVC>:/W0 /D_WIN32_WINNT=0x0A00 /EHsc /Zc:preprocessor>
66+
target_link_libraries(
67+
proto-library
68+
PRIVATE
69+
common-compile-settings
7170
)
7271

7372
set_target_properties(
@@ -136,11 +135,10 @@ if(${TRITON_COMMON_ENABLE_GRPC})
136135
$<BUILD_INTERFACE:${CMAKE_CURRENT_BINARY_DIR}>
137136
)
138137

139-
target_compile_options(
140-
grpc-service-library PRIVATE
141-
$<$<OR:$<CXX_COMPILER_ID:Clang>,$<CXX_COMPILER_ID:AppleClang>,$<CXX_COMPILER_ID:GNU>>:
142-
-Wall -Wextra -Wno-unused-parameter -Werror>
143-
$<$<CXX_COMPILER_ID:MSVC>:/W0 /D_WIN32_WINNT=0x0A00 /EHsc /Zc:preprocessor>
138+
target_link_libraries(
139+
grpc-service-library
140+
PRIVATE
141+
common-compile-settings
144142
)
145143

146144
set_target_properties(
@@ -193,11 +191,10 @@ if(${TRITON_COMMON_ENABLE_GRPC})
193191
$<BUILD_INTERFACE:${CMAKE_CURRENT_BINARY_DIR}>
194192
)
195193

196-
target_compile_options(
197-
grpc-health-library PRIVATE
198-
$<$<OR:$<CXX_COMPILER_ID:Clang>,$<CXX_COMPILER_ID:AppleClang>,$<CXX_COMPILER_ID:GNU>>:
199-
-Wall -Wextra -Wno-unused-parameter -Werror>
200-
$<$<CXX_COMPILER_ID:MSVC>:/W0 /D_WIN32_WINNT=0x0A00 /EHsc /Zc:preprocessor>
194+
target_link_libraries(
195+
grpc-health-library
196+
PRIVATE
197+
common-compile-settings
201198
)
202199

203200
set_target_properties(

0 commit comments

Comments
 (0)