Skip to content

Commit 07bb431

Browse files
mc-nvTabrizian
andauthored
Fix 'custom_ops' test configuration (#543)
* Update '--preload-path' value * Fix docker mnt volumes when LD_PRELOAD has colon Co-authored-by: Iman Tabrizian <[email protected]>
1 parent 9be6b62 commit 07bb431

File tree

2 files changed

+5
-2
lines changed

2 files changed

+5
-2
lines changed

qa/L0_custom_ops/test.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ TRITON_LOG_BASE="triton.log"
3434
WAIT_TIMEOUT=1200
3535

3636
# Generate test configs
37-
python3 test_config_generator.py --profile-models $MODEL_NAMES --preload-path $MODEL_REPOSITORY/libtorch_modulo/custom_modulo.so --library-path /opt/tritonserver/backends/pytorch:'$LD_LIBRARY_PATH'
37+
python3 test_config_generator.py --profile-models $MODEL_NAMES --preload-path "/usr/lib/x86_64-linux-gnu/libpython3.8.so.1:$MODEL_REPOSITORY/libtorch_modulo/custom_modulo.so" --library-path /opt/tritonserver/backends/pytorch:'$LD_LIBRARY_PATH'
3838

3939
LIST_OF_CONFIG_FILES=(`ls | grep .yaml`)
4040

qa/L0_custom_ops/test_config_generator.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -94,8 +94,11 @@ def generate_docker_mode_custom_op_config(self):
9494
if 'TRITON_LAUNCH_DOCKER_IMAGE' in os.environ:
9595
self.config['triton_docker_image'] = os.environ[
9696
'TRITON_LAUNCH_DOCKER_IMAGE']
97+
preload_paths = self.args.preload_path.split(':')
98+
# Only mount the second preload location. The first
99+
# location is available in the server container.
97100
self.config['triton_docker_mounts'] = [
98-
f'{self.args.preload_path}:{self.args.preload_path}:ro',
101+
f'{preload_paths[1]}:{preload_paths[1]}:ro'
99102
]
100103
self.config['triton_server_environment'] = {
101104
'LD_PRELOAD': self.args.preload_path,

0 commit comments

Comments
 (0)