Fix Coordinate comparison error (#717)

* Adding __lt__ to coordinate class

* Fixing codeQL issues

Author: nv-braf

model_analyzer/config/generate/coordinate.py

@@ -24,7 +24,7 @@ class Coordinate:
     def __init__(self, val: Union['Coordinate', List[int]]):
         """
         val: list
-            List of floats or integers cooresponding to the location in space
+            List of floats or integers corresponding to the location in space
         """
         if isinstance(val, Coordinate):
             val = val._values
@@ -74,6 +74,12 @@ def __eq__(self, other: Any) -> bool:
                 return False
         return True
 
+    def __lt__(self, other: Any) -> bool:
+        for i, v in enumerate(self._values):
+            if v != other[i]:
+                return v < other[i]
+        return False
+
     def round(self) -> None:
         """ Rounds the coordinate in-place """
         for i, _ in enumerate(self._values):

tests/test_coordinate.py

@@ -119,3 +119,18 @@ def test_enumerate(self):
     def test_stringification(self):
         c1 = Coordinate([2, 4, 1, 7])
         self.assertEqual("[2, 4, 1, 7]", c1.__str__())
+
+    def test_compare(self):
+        c1 = Coordinate([1, 3, 2])
+        c2 = Coordinate([1, 3, 2])
+        c3 = Coordinate([1, 3, 1])
+        c4 = Coordinate([1, 3, 3])
+        c5 = Coordinate([2, 1, 3])
+        c6 = Coordinate([0, 1, 3])
+
+        self.assertEqual(c1, c2)
+        self.assertGreater(c1, c3)
+        self.assertLess(c3, c1)
+        self.assertLess(c1, c4)
+        self.assertLess(c1, c5)
+        self.assertGreater(c1, c6)

tests/test_neighborhood.py

@@ -757,6 +757,7 @@ def test_all_same_throughputs(self):
         step_vector = n._get_step_vector()
         self.assertEqual(step_vector, Coordinate([0, 0, 0]))
 
+        n.force_slow_mode()
         new_coord = n.determine_new_home()
         self.assertEqual(new_coord, Coordinate([1, 1, 1]))