build: clean up build #971
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the-david-oy
changed the title
the-david-oy
changed the title
|
Converting this to a draft for now. Misha proposed an alternate way to clean up the build in a separate PR. If that goes through, I'll close this PR and submit a smaller one just focused on removing yapf and format.py. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the more standard requirements.txt for runtime requirements and requirements-dev.txt for development-only requirements. This will make it so that the requirements are in the project, not partially in the Dockerfile.
Also, remove format.py and all references to yapf, as they have not been used in a while. Pre-commit formatting hooks are used now instead.
Note: A lot of files were changed due to pre-commit running on them, since I touched the related lines to remove the yapf references. Those changes are confined to the second commit. This is passing CI.