Skip to content

Commit 5fd2ca6

Browse files
committed
re-order and update test comments
1 parent 76d5ec1 commit 5fd2ca6

File tree

1 file changed

+6
-5
lines changed

1 file changed

+6
-5
lines changed

qa/L0_backend_python/model_control/model_control_test.py

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -210,24 +210,25 @@ def __init__(self, error_msg):
210210
def test_invalid_character_model_names(self):
211211
"""Test that model names with invalid characters are properly rejected"""
212212

213-
# Model names with various invalid characters that should be rejected
214-
# Based on INVALID_CHARS = ";|&$<>(){}\\\"'`*?~#!"
213+
# Model names with various invalid characters that should be rejected. These requests are using curl to avoid the client encoding these values. Encoded model names are safe and can be accepted by the server.
214+
# Based on INVALID_CHARS = ";|&$`<>()[]{}\\\"'*?~#!"
215215
invalid_model_names = [
216216
r"model;test",
217217
r"model|test",
218218
r"model&test",
219219
r"model$test",
220+
r"model`test`",
220221
r"model<test>",
221222
r"model(test)",
223+
# r"model[test]", # request fails to send unencoded
222224
r"model{test}",
223225
r"model\test",
224226
r'model"test"',
225227
r"model'test'",
226-
r"model`test`",
227228
r"model*test",
228-
# r"model?test", # curl fails to send this request
229+
# r"model?test", # request fails to send unencoded
229230
r"model~test",
230-
# r"model#test", # curl fails to send this request
231+
# r"model#test", # request fails to send unencoded
231232
r"model!test",
232233
]
233234

0 commit comments

Comments
 (0)