Skip to content

Commit 0dadc8e

Browse files
committed
Test metrics are enabled by default if disable_log_stats is not set.
1 parent 56aea05 commit 0dadc8e

File tree

1 file changed

+34
-3
lines changed
  • ci/L0_backend_vllm/metrics_test

1 file changed

+34
-3
lines changed

ci/L0_backend_vllm/metrics_test/test.sh

Lines changed: 34 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ sed -i 's/"gpu_memory_utilization": 0.5/"gpu_memory_utilization": 0.4/' models/v
5858

5959
RET=0
6060

61-
# test vLLM metrics
61+
# Test vLLM metrics
6262
run_server
6363
if [ "$SERVER_PID" == "0" ]; then
6464
cat $SERVER_LOG
@@ -86,7 +86,7 @@ set -e
8686
kill $SERVER_PID
8787
wait $SERVER_PID
8888

89-
# test disabling vLLM metrics with disable_log_stats set to true
89+
# Test disabling vLLM metrics with disable_log_stats set to true
9090
sed -i 's/"disable_log_stats": false/"disable_log_stats": true/' models/vllm_opt/1/model.json
9191

9292
run_server
@@ -115,7 +115,38 @@ set -e
115115

116116
kill $SERVER_PID
117117
wait $SERVER_PID
118-
rm -rf "./models"
118+
119+
# Test vLLM metrics if disable_log_stats is not set in model.json
120+
jq 'del(.disable_log_stats)' models/vllm_opt/1/model.json > "temp.json"
121+
mv temp.json models/vllm_opt/1/model.json
122+
123+
run_server
124+
if [ "$SERVER_PID" == "0" ]; then
125+
cat $SERVER_LOG
126+
echo -e "\n***\n*** Failed to start $SERVER\n***"
127+
exit 1
128+
fi
129+
130+
set +e
131+
python3 $CLIENT_PY VLLMTritonMetricsTest.test_vllm_metrics -v > $CLIENT_LOG 2>&1
132+
133+
if [ $? -ne 0 ]; then
134+
cat $CLIENT_LOG
135+
echo -e "\n***\n*** Running $CLIENT_PY FAILED. \n***"
136+
RET=1
137+
else
138+
check_test_results $TEST_RESULT_FILE $EXPECTED_NUM_TESTS
139+
if [ $? -ne 0 ]; then
140+
cat $CLIENT_LOG
141+
echo -e "\n***\n*** Test Result Verification FAILED.\n***"
142+
RET=1
143+
fi
144+
fi
145+
set -e
146+
147+
kill $SERVER_PID
148+
wait $SERVER_PID
149+
rm -rf "./models" "temp.json"
119150

120151
if [ $RET -eq 1 ]; then
121152
cat $CLIENT_LOG

0 commit comments

Comments
 (0)