Skip to content

Commit a26a083

Browse files
committed
[chore] Set bool config param to accept only true/false - compat breaking
1 parent b6bd649 commit a26a083

File tree

3 files changed

+8
-8
lines changed

3 files changed

+8
-8
lines changed

README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -307,11 +307,11 @@ or left empty (false by default) in [model.json](https://github.com/triton-infer
307307
*Note:* vLLM metrics are not reported to Triton metrics server by default
308308
due to potential performance slowdowns. To enable vLLM model's metrics
309309
reporting, please add following lines to its config.pbtxt as well.
310-
```bash
310+
```
311311
parameters: {
312312
key: "REPORT_CUSTOM_METRICS"
313313
value: {
314-
string_value:"yes"
314+
string_value: "true"
315315
}
316316
}
317317
```

ci/L0_backend_vllm/metrics_test/test.sh

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -98,14 +98,14 @@ parameters: {
9898
" >> models/vllm_opt/config.pbtxt
9999
run_test VLLMTritonMetricsTest.test_vllm_metrics_disabled
100100

101-
# Test vLLM metrics reporting with parameter "REPORT_CUSTOM_METRICS" set to "yes" in config.pbtxt
101+
# Test vLLM metrics reporting with parameter "REPORT_CUSTOM_METRICS" set to "true" in config.pbtxt
102102
copy_model_repository
103103
cp ${SAMPLE_MODELS_REPO}/vllm_model/config.pbtxt models/vllm_opt
104104
echo -e "
105105
parameters: {
106106
key: \"REPORT_CUSTOM_METRICS\"
107107
value: {
108-
string_value:\"yes\"
108+
string_value: \"true\"
109109
}
110110
}
111111
" >> models/vllm_opt/config.pbtxt
@@ -120,7 +120,7 @@ echo -e "
120120
parameters: {
121121
key: \"REPORT_CUSTOM_METRICS\"
122122
value: {
123-
string_value:\"yes\"
123+
string_value: \"true\"
124124
}
125125
}
126126
" >> models/vllm_opt/config.pbtxt
@@ -134,7 +134,7 @@ echo -e "
134134
parameters: {
135135
key: \"REPORT_CUSTOM_METRICS\"
136136
value: {
137-
string_value:\"yes\"
137+
string_value: \"true\"
138138
}
139139
}
140140
" >> models/vllm_opt/config.pbtxt
@@ -146,7 +146,7 @@ echo -e "
146146
parameters: {
147147
key: \"REPORT_CUSTOM_METRICS\"
148148
value: {
149-
string_value:\"yes\"
149+
string_value: \"true\"
150150
}
151151
}
152152
" >> models/vllm_opt/config.pbtxt

src/model.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -236,7 +236,7 @@ def init_engine(self):
236236
def _get_bool_config_param(self, param_name: str) -> bool:
237237
return (param_name in self.model_config["parameters"]) and (
238238
self.model_config["parameters"][param_name]["string_value"].lower()
239-
in ["yes", "true"]
239+
== "true"
240240
)
241241

242242
def setup_lora(self):

0 commit comments

Comments
 (0)