Skip to content

Commit db4427f

Browse files
committed
Deprecate V0 engine
1 parent 60b444f commit db4427f

File tree

2 files changed

+10
-21
lines changed

2 files changed

+10
-21
lines changed

ci/L0_backend_vllm/accuracy_test/test.sh

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -48,17 +48,11 @@ RET=0
4848
set +e
4949
# Need to generate baseline first, since running 2 vLLM engines causes
5050
# memory issues: https://github.com/vllm-project/vllm/issues/2248
51-
export VLLM_USE_V1=0
52-
export VLLM_WORKER_MULTIPROC_METHOD=spawn
5351
python3 $CLIENT_PY --generate-baseline >> $VLLM_ENGINE_LOG 2>&1 & BASELINE_PID=$!
5452
wait $BASELINE_PID
5553

5654
python3 $CLIENT_PY --generate-guided-baseline > $VLLM_ENGINE_LOG 2>&1 & BASELINE_PID=$!
5755
wait $BASELINE_PID
58-
59-
unset VLLM_USE_V1
60-
unset VLLM_WORKER_MULTIPROC_METHOD
61-
6256
set -e
6357

6458
run_server
@@ -88,12 +82,6 @@ set -e
8882
kill $SERVER_PID
8983
wait $SERVER_PID
9084

91-
# Check that warning about V1 Engine appears in log - this warning is expected
92-
if ! grep -q "Engine in background thread is experimental on VLLM_USE_V1=1. Falling back to V0 Engine." $SERVER_LOG; then
93-
echo -e "\n***\n*** ERROR: Expected warning about vLLM falling back to V0 Engine not found in logs.\n***"
94-
RET=1
95-
fi
96-
9785
rm -rf models/
9886

9987
if [ $RET -eq 1 ]; then

ci/L0_check_health_vllm/test.sh

Lines changed: 10 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -48,23 +48,24 @@ function enable_health_check {
4848
}
4949

5050
VLLM_INSTALL_PATH="/usr/local/lib/python3.12/dist-packages/vllm"
51+
VLLM_V1_ENGINE_PATH="$VLLM_INSTALL_PATH/v1/engine"
5152

5253
function mock_vllm_async_llm_engine {
5354
# backup original file
54-
mv $VLLM_INSTALL_PATH/engine/multiprocessing/client.py $VLLM_INSTALL_PATH/engine/multiprocessing/client.py.backup
55-
cp $VLLM_INSTALL_PATH/engine/multiprocessing/client.py.backup $VLLM_INSTALL_PATH/engine/multiprocessing/client.py
55+
mv $VLLM_V1_ENGINE_PATH/async_llm.py $VLLM_V1_ENGINE_PATH/async_llm.py.backup
56+
cp $VLLM_V1_ENGINE_PATH/async_llm.py.backup $VLLM_V1_ENGINE_PATH/async_llm.py
5657
# overwrite the original check_health method
57-
echo -e "" >> $VLLM_INSTALL_PATH/engine/multiprocessing/client.py
58-
echo -e " async def check_health(self, check_count=[0]):" >> $VLLM_INSTALL_PATH/engine/multiprocessing/client.py
59-
echo -e " check_count[0] += 1" >> $VLLM_INSTALL_PATH/engine/multiprocessing/client.py
60-
echo -e " if check_count[0] > 1:" >> $VLLM_INSTALL_PATH/engine/multiprocessing/client.py
61-
echo -e " raise RuntimeError(\"Simulated vLLM check_health() failure\")" >> $VLLM_INSTALL_PATH/engine/multiprocessing/client.py
58+
echo -e "" >> $VLLM_V1_ENGINE_PATH/async_llm.py
59+
echo -e " async def check_health(self, check_count=[0]):" >> $VLLM_V1_ENGINE_PATH/async_llm.py
60+
echo -e " check_count[0] += 1" >> $VLLM_V1_ENGINE_PATH/async_llm.py
61+
echo -e " if check_count[0] > 1:" >> $VLLM_V1_ENGINE_PATH/async_llm.py
62+
echo -e " raise RuntimeError(\"Simulated vLLM check_health() failure\")" >> $VLLM_V1_ENGINE_PATH/async_llm.py
6263
}
6364

6465
function unmock_vllm_async_llm_engine {
6566
# restore from backup
66-
rm -f $VLLM_INSTALL_PATH/engine/multiprocessing/client.py
67-
mv $VLLM_INSTALL_PATH/engine/multiprocessing/client.py.backup $VLLM_INSTALL_PATH/engine/multiprocessing/client.py
67+
rm -f $VLLM_V1_ENGINE_PATH/async_llm.py
68+
mv $VLLM_V1_ENGINE_PATH/async_llm.py.backup $VLLM_V1_ENGINE_PATH/async_llm.py
6869
}
6970

7071
function test_check_health {

0 commit comments

Comments
 (0)