Skip to content

Commit 66012fc

Browse files
authored
[CI] Fix cache not saving (#5213)
#### Commits in this PR 1. [CI] Fix cache not saving Re-using the output of the cache restore step was recommended by the `actons/cache` docs, but it doesn't work here because we actually start from a clean cache when we run save so there is no output available to read. The annoyances of testing in the PR but main being a different environment. 2. Bump macOS timeout
1 parent cef2671 commit 66012fc

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

.github/workflows/integration-tests.yml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -309,7 +309,7 @@ jobs:
309309
path: |
310310
~/.triton/cache
311311
~/.ccache
312-
key: ${{ steps.restore-build-cache.outputs.cache-primary-key }}
312+
key: triton-artifacts-${{ runner.os }}-${{ runner.arch }}-${{ env.RUNNER_TYPE }}-llvm-${{ steps.cache-key.outputs.llvm }}-${{ steps.cache-key.outputs.datetime }}
313313
Integration-Tests-AMD:
314314
needs: Runner-Preparation
315315
if: needs.Runner-Preparation.outputs.matrix-HIP != ''
@@ -477,15 +477,15 @@ jobs:
477477
path: |
478478
~/.triton/cache
479479
~/.ccache
480-
key: ${{ steps.restore-build-cache.outputs.cache-primary-key }}
480+
key: triton-artifacts-${{ runner.os }}-${{ runner.arch }}-${{ env.RUNNER_TYPE }}-llvm-${{ steps.cache-key.outputs.llvm }}-${{ steps.cache-key.outputs.datetime }}
481481
- name: Clean up caches
482482
run: |
483483
rm -rf ~/.triton/cache
484484
Build-Tests:
485485
needs: Runner-Preparation
486486
if: needs.Runner-Preparation.outputs.matrix-MACOS != ''
487487
runs-on: ${{ matrix.runner }}
488-
timeout-minutes: 30
488+
timeout-minutes: 40
489489
strategy:
490490
matrix:
491491
runner: ${{fromJson(needs.Runner-Preparation.outputs.matrix-MACOS)}}
@@ -605,4 +605,4 @@ jobs:
605605
path: |
606606
~/.triton/cache
607607
~/.ccache
608-
key: ${{ steps.restore-build-cache.outputs.cache-primary-key }}
608+
key: triton-artifacts-${{ runner.os }}-${{ runner.arch }}-${{ env.RUNNER_TYPE }}-llvm-${{ steps.cache-key.outputs.llvm }}-${{ steps.cache-key.outputs.datetime }}

.github/workflows/integration-tests.yml.in

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -349,7 +349,7 @@ jobs:
349349
path: |
350350
~/.triton/cache
351351
~/.ccache
352-
key: ${{ steps.restore-build-cache.outputs.cache-primary-key }}
352+
key: triton-artifacts-${{ runner.os }}-${{ runner.arch }}-${{ env.RUNNER_TYPE }}-llvm-${{ steps.cache-key.outputs.llvm }}-${{ steps.cache-key.outputs.datetime }}
353353

354354
Integration-Tests-AMD:
355355
needs: Runner-Preparation
@@ -452,7 +452,7 @@ jobs:
452452
needs: Runner-Preparation
453453
if: needs.Runner-Preparation.outputs.matrix-MACOS != ''
454454
runs-on: ${{ matrix.runner }}
455-
timeout-minutes: 30
455+
timeout-minutes: 40
456456
strategy:
457457
matrix:
458458
runner: ${{fromJson(needs.Runner-Preparation.outputs.matrix-MACOS)}}

0 commit comments

Comments
 (0)