Skip to content

Commit 8733bda

Browse files
committed
address review comments on naming
1 parent ee86c63 commit 8733bda

File tree

2 files changed

+9
-9
lines changed

2 files changed

+9
-9
lines changed

third_party/amd/include/Dialect/TritonAMDGPU/IR/TritonAMDGPUOpInterfaces.td

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
1-
#ifndef AMDGPU_OP_INTERFACES
2-
#define AMDGPU_OP_INTERFACES
1+
#ifndef TRITON_AMDGPU_OP_INTERFACES
2+
#define TRITON_AMDGPU_OP_INTERFACES
33

44
include "mlir/IR/OpBase.td"
55

6-
def BufferOpAddressinInterface : OpInterface<"BufferOpAddressinInterface"> {
6+
def BufferOpInterface : OpInterface<"BufferOpInterface"> {
77
let description = [{
88
This interface is implemented by buffer load/store operations.
99
It provides methods to access common properties such base pointer, offset, mask and others.
@@ -39,4 +39,4 @@ def BufferOpAddressinInterface : OpInterface<"BufferOpAddressinInterface"> {
3939
];
4040
}
4141

42-
#endif // AMDGPU_OP_INTERFACES
42+
#endif // TRITON_AMDGPU_OP_INTERFACES

third_party/amd/include/Dialect/TritonAMDGPU/IR/TritonAMDGPUOps.td

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -284,7 +284,7 @@ def CondBarrierOp : TT_AMDGPU_Op<"cond_barrier"> {
284284
def BufferLoadOp : TT_AMDGPU_Op<"buffer_load", [
285285
SameLoadStoreOperandsAndResultEncoding,
286286
AttrSizedOperandSegments,
287-
BufferOpAddressinInterface,
287+
BufferOpInterface,
288288
TypesMatchWith<"result element type matches the pointed type of ptr", "result", "ptr", "getPointerTypeToElement($_self)">,
289289
TypesMatchWith<"result and offsets have the same shape", "result", "offsets", "getI32SameShape($_self)">,
290290
TypesMatchWith<"result and mask have the same shape", "result", "mask", "getI1SameShape($_self)",
@@ -330,7 +330,7 @@ def BufferLoadOp : TT_AMDGPU_Op<"buffer_load", [
330330

331331
def BufferLoadToLocalOp : TT_AMDGPU_Op<"buffer_load_to_local", [
332332
AttrSizedOperandSegments,
333-
BufferOpAddressinInterface,
333+
BufferOpInterface,
334334
TypesMatchWith<"dest element type matches pointee type of ptr", "dest", "ptr", "getPointerTypeToElement($_self)">,
335335
TypesMatchWith<"infer mask shape from offsets",
336336
"offsets", "mask", "getI1SameShape($_self)",
@@ -367,7 +367,7 @@ def BufferLoadToLocalOp : TT_AMDGPU_Op<"buffer_load_to_local", [
367367
def BufferAtomicRMWOp : TT_AMDGPU_Op<"buffer_atomic_rmw", [
368368
AttrSizedOperandSegments,
369369
SameLoadStoreOperandsAndResultEncoding,
370-
BufferOpAddressinInterface,
370+
BufferOpInterface,
371371
TypesMatchWith<"result element type matches the value type", "result", "value", "$_self">,
372372
TypesMatchWith<"result element type matches the pointed type of ptr", "result", "ptr", "getPointerTypeToElement($_self)">,
373373
TypesMatchWith<"result and offsets have the same shape", "result", "offsets", "getI32SameShape($_self)">,
@@ -414,7 +414,7 @@ def BufferAtomicRMWOp : TT_AMDGPU_Op<"buffer_atomic_rmw", [
414414
//===----------------------------------------------------------------------===//
415415
def BufferAtomicCASOp : TT_AMDGPU_Op<"buffer_atomic_cas", [
416416
SameLoadStoreOperandsAndResultEncoding,
417-
BufferOpAddressinInterface,
417+
BufferOpInterface,
418418
TypesMatchWith<"result element type matches the val type", "result", "val", "$_self">,
419419
TypesMatchWith<"result element type matches the cmp type", "result", "cmp", "$_self">,
420420
TypesMatchWith<"result element type matches the pointed type of ptr", "result", "ptr", "getPointerTypeToElement($_self)">,
@@ -457,7 +457,7 @@ def BufferAtomicCASOp : TT_AMDGPU_Op<"buffer_atomic_cas", [
457457
def BufferStoreOp : TT_AMDGPU_Op<"buffer_store", [
458458
AttrSizedOperandSegments,
459459
SameLoadStoreOperandsEncoding,
460-
BufferOpAddressinInterface,
460+
BufferOpInterface,
461461
TypesMatchWith<"value element type matches the pointed type of ptr", "value", "ptr", "getPointerTypeToElement($_self)">,
462462
TypesMatchWith<"value and offsets have the same shape", "value", "offsets", "getI32SameShape($_self)">,
463463
TypesMatchWith<"value and mask have the same shape", "value", "mask", "getI1SameShape($_self)",

0 commit comments

Comments
 (0)