[PROTON] Explicitly list all cpp files (#5756)

Otherwise, sometimes on macOS we may generate unnecessary files with a
`_` prefix after unpacking a tar file.

Author: Jokeren

third_party/proton/CMakeLists.txt

@@ -1,37 +1,73 @@
-project(Proton CXX)
+project(Proton LANGUAGES CXX)
 
-set(PROTON_SRC_DIR ${CMAKE_CURRENT_SOURCE_DIR}/csrc)
-set(PROTON_EXTERN_DIR ${CMAKE_CURRENT_SOURCE_DIR}/extern)
-file(GLOB_RECURSE PROTON_SRC ${PROTON_SRC_DIR}/lib/*.cpp)
-add_library(proton SHARED ${PROTON_SRC} ${PROTON_SRC_DIR}/${PROJECT_NAME}.cpp)
+set(PROTON_SRC_DIR "${CMAKE_CURRENT_SOURCE_DIR}/csrc")
 
+# ============ Check for includes =============
 if(NOT CUPTI_INCLUDE_DIR)
   message(FATAL_ERROR "CUPTI include directory not defined")
 endif()
 if(NOT ROCTRACER_INCLUDE_DIR)
   message(FATAL_ERROR "ROCTRACER include directory not defined")
 endif()
-if (NOT JSON_INCLUDE_DIR)
+if(NOT JSON_INCLUDE_DIR)
   message(FATAL_ERROR "JSON include directory not defined")
 endif()
 
-include_directories(${JSON_INCLUDE_DIR})
-include_directories(${PROTON_SRC_DIR}/include)
-include_directories(${PROTON_EXTERN_DIR})
-
+# ============ Dependencies =============
 find_package(Python3 REQUIRED Interpreter Development.Module)
 find_package(pybind11 CONFIG REQUIRED HINTS "${Python3_SITELIB}")
 
-# Check if the platform is MacOS
+# ============ Define a GLOBAL property to store object-libraries ============
+set_property(GLOBAL PROPERTY PROTON_LIBS "")
+
+# ============ Define a function to create object libraries ============
+function(add_proton_library name)
+  add_library(${name} OBJECT ${ARGN})
+
+  target_link_libraries(${name} PRIVATE Python3::Module pybind11::headers)
+
+  target_include_directories(${name}
+    PRIVATE
+      "${CUPTI_INCLUDE_DIR}"
+      "${ROCTRACER_INCLUDE_DIR}"
+      "${JSON_INCLUDE_DIR}"
+      "${PROTON_SRC_DIR}/include"
+  )
+
+  # If HIP is AMD-based
+  target_compile_definitions(${name} PRIVATE __HIP_PLATFORM_AMD__)
+
+  # Append this library name to the GLOBAL property "PROTON_LIBS"
+  set_property(GLOBAL APPEND PROPERTY PROTON_LIBS ${name})
+endfunction()
+
+# ============ Add subdirectory with actual code that calls add_proton_library ============
+add_subdirectory("${PROTON_SRC_DIR}")
+
+# ============ Possibly handle macOS specifics ============
 if(APPLE)
   set(CMAKE_SHARED_LIBRARY_SUFFIX ".so")
   # Other platforms build with -flto, but we found that this adds significant overhead to our macos CI without providing a major benefit.
   set(PROTON_PYTHON_LDFLAGS "-undefined dynamic_lookup")
 endif()
 
-include_directories(${CUPTI_INCLUDE_DIR})
-include_directories(SYSTEM ${ROCTRACER_INCLUDE_DIR})
-target_compile_definitions(proton PRIVATE __HIP_PLATFORM_AMD__)
+# ============ Collect all object libraries from property and build final shared lib ============
+get_property(_proton_obj_libs GLOBAL PROPERTY PROTON_LIBS)
+
+if(NOT _proton_obj_libs)
+  message(WARNING "No object libraries were defined in 'PROTON_LIBS'!")
+endif()
+
+set(_proton_obj_sources "")
+foreach(_lib IN LISTS _proton_obj_libs)
+  list(APPEND _proton_obj_sources $<TARGET_OBJECTS:${_lib}>)
+  message(STATUS "Collecting object files from ${_lib}")
+endforeach()
+
+add_library(proton SHARED ${_proton_obj_sources})
 
-target_link_libraries(proton PRIVATE Python3::Module pybind11::headers)
-target_link_options(proton PRIVATE ${PROTON_PYTHON_LDFLAGS})
+target_link_libraries(proton PRIVATE Python3::Module)
+# Apply any macOS linker flags or extra link options
+if(PROTON_PYTHON_LDFLAGS)
+  target_link_options(proton PRIVATE ${PROTON_PYTHON_LDFLAGS})
+endif()

third_party/proton/csrc/CMakeLists.txt

@@ -0,0 +1,5 @@
+add_proton_library(Proton
+	Proton.cpp
+)
+
+add_subdirectory(lib)

third_party/proton/csrc/lib/CMakeLists.txt

@@ -0,0 +1,5 @@
+add_subdirectory(Context)
+add_subdirectory(Data)
+add_subdirectory(Driver)
+add_subdirectory(Profiler)
+add_subdirectory(Session)

third_party/proton/csrc/lib/Context/CMakeLists.txt

@@ -0,0 +1,5 @@
+add_proton_library(ProtonContext
+	Context.cpp
+	Python.cpp
+	Shadow.cpp
+)

third_party/proton/csrc/lib/Data/CMakeLists.txt

@@ -0,0 +1,5 @@
+add_proton_library(ProtonData
+	Data.cpp
+	TraceData.cpp
+	TreeData.cpp
+)

third_party/proton/csrc/lib/Driver/CMakeLists.txt

@@ -0,0 +1,8 @@
+add_proton_library(ProtonDriver
+	Device.cpp
+	GPU/CudaApi.cpp
+	GPU/CuptiApi.cpp
+	GPU/HipApi.cpp
+	GPU/HsaApi.cpp
+	GPU/RoctracerApi.cpp
+)

third_party/proton/csrc/lib/Profiler/CMakeLists.txt

@@ -0,0 +1,5 @@
+add_proton_library(ProtonProfiler
+	Cupti/CuptiPCSampling.cpp
+	Cupti/CuptiProfiler.cpp
+	RocTracer/RoctracerProfiler.cpp
+)

third_party/proton/csrc/lib/Session/CMakeLists.txt

@@ -0,0 +1,3 @@
+add_proton_library(ProtonSession
+  Session.cpp
+)