Skip to content

Conversation

@gflegar
Copy link
Collaborator

@gflegar gflegar commented Dec 4, 2024

This is a chain on top of #5334, and includes those changes as well. Merge #5334 first to remove the diff.

The only new change here is the LLVM version bump.

wkpark and others added 3 commits December 4, 2024 09:09
from triton-lang#2757

 * fix deprecation warning
 * use bash shell to fix `az storage ...` console  error.
* `-DLLVM_ENABLE_DIA_SDK=OFF` added to fix `DIA_SDK` dependency -
`"ninja: error: 'C:/Program Files/Microsoft Visual
Studio/2022/Enterprise/DIA SDK/lib/amd64/diaguids.lib', needed by
'D:/src/triton/python/build/lib.win-amd64-cpython-310/triton/_C/libtriton.pyd',
missing and no known rule to make it"`.

the latest windows llvm build is available at
https://github.com/wkpark/triton/releases/tag/llvm-82f5acfb-windows

It would be nice to have default llvm;mlir compiler on the official
trion build system for someone who trying to develop solve some windows
related issue even if windows is not officially supported.

p.s.: and I'd like to thank all triton developers for their hard work!
Right now we are hitting the following issues in

https://github.com/triton-lang/triton/actions/runs/12148740919/job/33877869004:

> The macOS-12 environment is deprecated, consider switching to
> macOS-13, macOS-14 (macos-latest) or macOS-15. For more details,
> see actions/runner-images#10721
@gflegar gflegar requested a review from ptillet as a code owner December 4, 2024 13:27
@ThomasRaoux
Copy link
Collaborator

the last bump caused functional regressions, so there is a bug we need to narrow down before we can upgrade

@gflegar
Copy link
Collaborator Author

gflegar commented Dec 5, 2024

Right, I assume this is #5341, and blocked on re-reverting it.

@ThomasRaoux
Copy link
Collaborator

closing as this is out of date

@ThomasRaoux ThomasRaoux closed this Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants