[PIPELINER] Use AttrHelper (mostly NFC) #6437
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Converted ad-hoc attribute handling to AttrHelpers to ensure consistency * Changed `tt_latency` to `tt.latency` in AssignLatencies
Contributor
Author
|
@pawelszczerbuk is this change correct? I couldn't see where |
Mogball
reviewed
Apr 14, 2025
Collaborator
Mogball
left a comment
Mogball
left a comment
There was a problem hiding this comment.
This seems like a good thing. Can we delete kLatencyAttrName now?
| } | ||
|
|
||
| DenseMap<Operation *, int> mlir::triton::deserializeLatencies(Operation *op) { | ||
| auto helper = op->getContext() |
Collaborator
There was a problem hiding this comment.
suggestion: can you add a shorthand for this in Triton/Dialect.h?
Contributor
Author
There was a problem hiding this comment.
well.. I guess Medhi and River are not big fans..
Contributor
Author
Not sure as there is still some ambiguity with |
Mogball
approved these changes
Apr 15, 2025
njriasan
pushed a commit
to njriasan/triton
that referenced
this pull request
Apr 18, 2025
* Converted ad-hoc attribute handling to AttrHelpers to ensure consistency * Changed `tt_latency` to `tt.latency` in AssignLatencies?
FindHao
pushed a commit
to FindHao/triton
that referenced
this pull request
Apr 30, 2025
* Converted ad-hoc attribute handling to AttrHelpers to ensure consistency * Changed `tt_latency` to `tt.latency` in AssignLatencies?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tt_latencytott.latencyin AssignLatencies?