Skip to content

MMOItems max consumable doesn't update #532

@diogotcorreia

Description

@diogotcorreia

When using MMOItems, the max-consume lore does not update if it contains a Triton placeholder.
This probably happens because the plugin tries to replace the translated lore instead of the original one (?).

MMOItems version: git-1060ea8af8b489a96a9b551b1bb6a5ee14ac97ed (with patch to build successfully)
MythicLib version: git-27d7e9561eb53b1914ebea03d6ea568b6c8352d9

Relevant codepath: https://gitlab.com/phoenix-dvpmt/mmoitems/-/blob/7f38c2910045b5c429a46e6bdff294f38984ced7/MMOItems-API/src/main/java/net/Indyuce/mmoitems/api/interaction/Consumable.java#L102-L106

Additional context: https://discord.com/channels/395565283047374850/395566597860884480/1394409207511650496


Test instructions:

  • Add placeholder to max-consume in language/stats.yml
  • /mi browse
  • Pick a consumable
  • Edit it to add a max consumable number (last page I think)
  • Try to consume it by right clicking

This bug is related to the fact that we don't restore the original nbt data on incoming packets

Metadata

Metadata

Assignees

Labels

module:spigotRelated to Spigot/PaperMCtype:bugSomething isn't working as expected

Type

No type

Projects

Status

In Progress

Relationships

None yet

Development

No branches or pull requests

Issue actions