No %s substitution in variants

[tgriessbach]

Hello all,
my system is
TYPO3 11.5
PHP 8.1
form_element_linked_checkbox 4.0.0

I have the following yaml configuration:

renderables:
  - identifier: gdpr
	type: LinkedCheckbox
	label: 'Ich stimme zu... Ich habe die %s zur Kenntnis genommen...'
	properties:
	  pageUid: 236
	  linkText: 'Datenschutzerklärung'
	  fluidAdditionalAttributes:
		required: required
	variants:
	  - identifier: gdpr-en
		condition: 'siteLanguage("locale") == "en_US.UTF-8"'
		label: 'I agree that my data... I have taken note of the %s, in particular...'
		properties:
		  pageUid: 236
		  linkText: 'privacy policy'

In the default Language (here german) the %s is substituted correctly.
But in the translation variant the label is shown unchanged:

I agree that my data... I have taken note of the %s, in particular...

So translation works but not the substitution.
Is my configuration wrong?
The target page has an active translation, so the link building shoud not be the issue.

I tested form_element_linked_checkbox v3.0.0 and it has the same problem.

[chrisi51]

Hey @tgriessbach
i do the following:

identifier: kontakt
renderables:
  -
    renderables:
      -
        properties:
          linkText: 'privacy policy'
          fluidAdditionalAttributes:
            required: required
        type: LinkedCheckbox
        identifier: privacypolicy
        label: 'I have read and agree the %s.'

and having languages files with such a content:

      <trans-unit id="kontakt.element.privacypolicy.properties.label">
          <source>I have read and agree the %s.</source>
          <target>Ich habe die %s gelesen und bin damit einverstanden.</target>
      </trans-unit>

[eliashaeussler]

Hi @tgriessbach, variants should be respected since #53. I'll check what's going on there. In the meantime, can you try using the alternative implementation which @chrisi51 described?

[Rall3n]

@eliashaeussler Variants are processed at multiple points in the form rendering process:

• At initialization before the afterInitializeCurrentPage hook,
• Shortly before the form is actually rendered
• and when finishers are invoked.

I think the hook beforeRendering would be better suited, as it runs after any processVariants calls have been made.
The hook is called at two places:

• before the form is rendered in its entirety (second parameter is of type \TYPO3\CMS\Form\Domain\Model\FormDefinition)
• before a single form element is being rendered (via RenderRenderableViewHelper).

[tgriessbach]

Hey,
sorry for the late feedback.
The alternative from @chrisi51 works for me, thank you!

So I leave it to you if you want to close this ticket or keep it open for a "real" fix ;-)