Support URL-encoded asset names in getBaseImageUrl (#9)

* Support URL-encoded asset names in getBaseImageUrl

* Update CHANGELOG

* Fix lint issues. Add prettier

Author: frvge

CHANGELOG.md

@@ -2,6 +2,12 @@
 
 ## master
 
+### Bugfix
+
+- [#7](https://github.com/trivago/babel-plugin-cloudinary/issues/7) Support asset names in `getBaseImageUrl` that are URL-encoded by Cloudinary API.
+
+### Features
+
 - Update dependencies based on npm's security audit
 
 ## [0.0.1](https://github.com/trivago/babel-plugin-cloudinary/tree/0.0.1)

lib/cloudinary-proxy.js

@@ -38,7 +38,7 @@ function getBaseImageUrl(assetName, transforms) {
     url = url.replace(BASE_URL_PLACEHOLDER, runConfig.host);
   }
 
-  return url.split(assetName)[0];
+  return decodeURIComponent(url).split(assetName)[0];
 }
 
 module.exports = {

package-lock.json

@@ -52,6 +52,7 @@
     "jest": "^24.8.0",
     "lint-staged": "^8.1.3",
     "nodemon": "^1.18.9",
+    "prettier": "^1.18.2",
     "typescript": "^3.2.4"
   },
   "repository": {

package.json

@@ -0,0 +1,29 @@
+const { getBaseImageUrl } = require("../lib/cloudinary-proxy");
+
+jest.mock(
+  "../cloudinaryrc.json",
+  () => ({
+    native: {
+      // eslint-disable-next-line camelcase
+      cloud_name: "trivago",
+      secure: true,
+    },
+    host: "trivago.images.com",
+    overrideBaseUrl: true,
+  }),
+  { virtual: true }
+);
+
+describe("cloudinary-proxy", () => {
+  it("has proper output for getBaseImageUrl 1", () => {
+    const expected = "https://trivago.images.com/";
+
+    expect(getBaseImageUrl("myfile.jpg")).toEqual(expected);
+  });
+
+  it("has proper output for getBaseImageUrl 2", () => {
+    const expected = "https://trivago.images.com/";
+
+    expect(getBaseImageUrl("[email protected]")).toEqual(expected);
+  });
+});