Skip to content

Restrict HOHQMesh_jll compatibility version#97

Merged
ranocha merged 1 commit intomainfrom
ranocha-patch-1
Apr 2, 2026
Merged

Restrict HOHQMesh_jll compatibility version#97
ranocha merged 1 commit intomainfrom
ranocha-patch-1

Conversation

@ranocha
Copy link
Copy Markdown
Member

@ranocha ranocha commented Mar 27, 2026

We also use the same approach in P4est.jl. The issue is that we do not run real CI tests when releasing a new version of jll packages. Thus, we chose to fix the jll version in the Julia wrapper to get a chance to test new versions of jll packages before "really" releasing them.

CompatHelper should notify us about updates of HOHQMESH_jll. Whenever this is the case, we should update the compat bound to a new =X.Y.Z version.

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 27, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.84%. Comparing base (41403f3) to head (aff32b8).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #97   +/-   ##
=======================================
  Coverage   98.84%   98.84%           
=======================================
  Files          21       21           
  Lines        1900     1900           
=======================================
  Hits         1878     1878           
  Misses         22       22           
Flag Coverage Δ
unittests 98.84% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@coveralls
Copy link
Copy Markdown

Coverage Status

coverage: 98.842%. remained the same
when pulling aff32b8 on ranocha-patch-1
into 41403f3 on main.

@andrewwinters5000
Copy link
Copy Markdown
Member

Interesting, so we still run the tests for v1.5.1 but the tarball for v1.5.5 is available for users? How would I check (or change) the HOHQMesh_jll I use in my local development? I do not see it in my Pkg.status()?

@ranocha
Copy link
Copy Markdown
Member Author

ranocha commented Mar 27, 2026

You cannot use HOHQMesh_jll with the released version of HOHQMesh.jl if we merge this PR and release the new HOHQMESH.jl version. This prevents anybody from running into issues with a HOHQMESH_jll that was never tested in CI with HOHQMesh.jl.

If you want to test the new HOHQMesh_jll locally, you need to adapt the line I changed in this PR to the version number of HOHQMesh_jll you would like to test.

@ranocha
Copy link
Copy Markdown
Member Author

ranocha commented Apr 2, 2026

@andrewwinters5000 Shall we merge this to fix the issue with the current jll?

@andrewwinters5000
Copy link
Copy Markdown
Member

Sure, we can merge this such that the other open PRs from Daniel and dependabot can be merged as well. I still need to wrap my head around exactly what I did wrong with the tarball build.

@ranocha ranocha merged commit 853acfd into main Apr 2, 2026
10 checks passed
@ranocha ranocha deleted the ranocha-patch-1 branch April 2, 2026 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants