Add tests comparing neighbor lists to trivial NHS (#15)

* Add tests comparing neighbor lists to trivial NHS

* Extract search radius

* Add `Random` as test dependency

* Remove `using StaticArrays`

Author: efaulhaber

test/Project.toml

@@ -1,4 +1,5 @@
 [deps]
+Random = "9a3f8284-a2c9-5f02-9a11-845980a1fd5c"
 Test = "8dfed614-e22c-5e08-85e1-65c5234f0b40"
 
 [compat]

test/neighborhood_search.jl

@@ -1,6 +1,6 @@
 # This file contains tests for the generic functions in `src/neighborhood_search.jl` and
 # tests comparing all NHS implementations against the `TrivialNeighborhoodSearch`.
-@testset verbose=true "Neighborhood Searches" begin
+@testset verbose=true "All Neighborhood Searches" begin
     @testset verbose=true "Periodicity" begin
         # These examples are constructed by hand and are therefore a good test for the
         # trivial neighborhood search as well.
@@ -76,4 +76,70 @@
             end
         end
     end
+
+    @testset verbose=true "Compare Against `TrivialNeighborhoodSearch`" begin
+        cloud_sizes = [
+            (10, 11),
+            (100, 90),
+            (9, 10, 7),
+            (39, 40, 41),
+        ]
+
+        seeds = [1, 2]
+        @testset verbose=true "$(length(cloud_size))D with $(prod(cloud_size)) Particles ($(seed == 1 ? "`initialize!`" : "`update!`"))" for cloud_size in cloud_sizes,
+                                                                                                                                             seed in seeds
+
+            coords = point_cloud(cloud_size, seed = seed)
+            NDIMS = length(cloud_size)
+            search_radius = 2.5
+
+            # Use different coordinates for `initialize!` and then `update!` with the
+            # correct coordinates to make sure that `update!` is working as well.
+            coords_initialize = point_cloud(cloud_size, seed = 1)
+
+            # Compute expected neighbor lists by brute-force looping over all particles
+            # as potential neighbors (`TrivialNeighborhoodSearch`).
+            trivial_nhs = TrivialNeighborhoodSearch{NDIMS}(search_radius, axes(coords, 2))
+
+            neighbors_expected = [Int[] for _ in axes(coords, 2)]
+
+            for_particle_neighbor(coords, coords, trivial_nhs,
+                                  parallel = false) do particle, neighbor,
+                                                       pos_diff, distance
+                append!(neighbors_expected[particle], neighbor)
+            end
+
+            neighborhood_searches = [
+                GridNeighborhoodSearch{NDIMS}(search_radius, size(coords, 2)),
+            ]
+
+            neighborhood_searches_names = [
+                "`GridNeighborhoodSearch`",
+            ]
+
+            @testset "$(neighborhood_searches_names[i])" for i in eachindex(neighborhood_searches_names)
+                nhs = neighborhood_searches[i]
+
+                # Initialize with `seed = 1`
+                initialize!(nhs, coords_initialize, coords_initialize)
+
+                # For other seeds, update with the correct coordinates.
+                # This way, we test only `initialize!` when `seed == 1`,
+                # and `initialize!` plus `update!` else.
+                if seed != 1
+                    update!(nhs, coords, coords)
+                end
+
+                neighbors = [Int[] for _ in axes(coords, 2)]
+
+                for_particle_neighbor(coords, coords, nhs,
+                                      parallel = false) do particle, neighbor,
+                                                           pos_diff, distance
+                    append!(neighbors[particle], neighbor)
+                end
+
+                @test sort.(neighbors) == neighbors_expected
+            end
+        end
+    end
 end;

test/point_cloud.jl

@@ -0,0 +1,29 @@
+using Random
+
+# Generate a rectangular point cloud, optionally with a perturbation in the point positions
+function point_cloud(n_points_per_dimension;
+                     seed = 1, perturbation_factor_position = 1.0)
+    # Fixed seed to ensure reproducibility
+    Random.seed!(seed)
+
+    n_dims = length(n_points_per_dimension)
+    coordinates = Array{Float64}(undef, n_dims, prod(n_points_per_dimension))
+    cartesian_indices = CartesianIndices(n_points_per_dimension)
+
+    for i in axes(coordinates, 2)
+        coordinates[:, i] .= Tuple(cartesian_indices[i])
+    end
+
+    perturb!(coordinates, perturbation_factor_position * 0.5)
+
+    return coordinates
+end
+
+function perturb!(data, amplitude)
+    for i in eachindex(data)
+        # Perturbation in the interval (-amplitude, amplitude)
+        data[i] += 2 * amplitude * rand() - amplitude
+    end
+
+    return data
+end

test/test_util.jl

@@ -74,3 +74,5 @@ macro test_nowarn_mod(expr, additional_ignore_content = String[])
         end
     end
 end
+
+include("point_cloud.jl")