Skip to content

Commit 01dfdb3

Browse files
ranochaDanielDoehringJoshuaLampert
authored
update to TrixiTest.jl v2 (#2683)
* update to TrixiTest.jl v2 * up * up * up * Update test/test_tree_2d_mhd.jl Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Update test/test_p4est_2d.jl * Update test/test_tree_2d_mhd.jl * change * Apply suggestions from code review * fix * comments * Update test/Project.toml * Apply suggestions from code review * Update test/test_structured_2d.jl * Update test/test_p4est_3d.jl * Update test/test_structured_2d.jl Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Update test/test_structured_2d.jl --------- Co-authored-by: Daniel Doehring <daniel.doehring@rwth-aachen.de> Co-authored-by: Joshua Lampert <51029046+JoshuaLampert@users.noreply.github.com>
1 parent 593e3ee commit 01dfdb3

File tree

6 files changed

+12
-12
lines changed

6 files changed

+12
-12
lines changed

test/Project.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -74,4 +74,4 @@ SparseConnectivityTracer = "1.0.1"
7474
SparseMatrixColorings = "0.4.21"
7575
StableRNGs = "1.0.2"
7676
Test = "1"
77-
TrixiTest = "0.1.4"
77+
TrixiTest = "0.2.1"

test/test_cuda.jl

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ EXAMPLES_DIR = joinpath(examples_dir(), "p4est_2d_dgsem")
2222
@test real(ode.p.solver) == Float64
2323
@test real(ode.p.solver.basis) == Float64
2424
@test real(ode.p.solver.mortar) == Float64
25-
# TODO: remake ignores the mesh itself as well
25+
# TODO: `mesh` is currently not `adapt`ed correctly
2626
@test real(ode.p.mesh) == Float64
2727

2828
@test ode.u0 isa Array
@@ -41,7 +41,7 @@ end
4141
# Expected errors are exactly the same as with TreeMesh!
4242
l2=nothing, # TODO: GPU. [Float32(8.311947673061856e-6)],
4343
linf=nothing, # TODO: GPU. [Float32(6.627000273229378e-5)],
44-
RealT=Float32,
44+
RealT_for_test_tolerances=Float32,
4545
real_type=Float32,
4646
storage_type=CuArray,
4747
sol=nothing,) # TODO: GPU. Remove this once we can run the simulation on the GPU
@@ -51,7 +51,7 @@ end
5151
@test real(ode.p.solver) == Float32
5252
@test real(ode.p.solver.basis) == Float32
5353
@test real(ode.p.solver.mortar) == Float32
54-
# TODO: remake ignores the mesh itself as well
54+
# TODO: `mesh` is currently not `adapt`ed correctly
5555
@test real(ode.p.mesh) == Float64
5656

5757
@test ode.u0 isa CuArray

test/test_p4est_2d.jl

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ isdir(outdir) && rm(outdir, recursive = true)
2626
@test real(semi32.solver) == Float32
2727
@test real(semi32.solver.basis) == Float32
2828
@test real(semi32.solver.mortar) == Float32
29-
# TODO: remake ignores the mesh itself as well
29+
# TODO: `mesh` is currently not `adapt`ed correctly
3030
@test real(semi32.mesh) == Float64
3131
end
3232

@@ -35,7 +35,7 @@ end
3535
# Expected errors are exactly the same as with TreeMesh!
3636
l2=[Float32(8.311947673061856e-6)],
3737
linf=[Float32(6.627000273229378e-5)],
38-
RealT=Float32,
38+
RealT_for_test_tolerances=Float32,
3939
real_type=Float32)
4040
# Ensure that we do not have excessive memory allocations
4141
# (e.g., from type instabilities)
@@ -48,7 +48,7 @@ end
4848
@test real(ode.p.solver) == Float32
4949
@test real(ode.p.solver.basis) == Float32
5050
@test real(ode.p.solver.mortar) == Float32
51-
# TODO: remake ignores the mesh itself as well
51+
# TODO: `mesh` is currently not `adapt`ed correctly
5252
@test real(ode.p.mesh) == Float64
5353
end
5454

@@ -278,7 +278,7 @@ end
278278
],
279279
tspan=(0.0f0, 1.0f0),
280280
rtol=10 * sqrt(eps(Float32)), # to make CI pass
281-
RealT=Float32)
281+
RealT_for_test_tolerances=Float32)
282282
# Ensure that we do not have excessive memory allocations
283283
# (e.g., from type instabilities)
284284
@test_allocations(Trixi.rhs!, semi, sol, 1000)

test/test_p4est_3d.jl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -228,7 +228,7 @@ end
228228
Float32(2.298161660974074e-14),
229229
Float32(6.039613253960852e-14)
230230
],
231-
RealT=Float32)
231+
RealT_for_test_tolerances=Float32)
232232
# Ensure that we do not have excessive memory allocations
233233
# (e.g., from type instabilities)
234234
@test_allocations(Trixi.rhs!, semi, sol, 1000)

test/test_structured_2d.jl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ end
3030
# Expected errors are taken from elixir_advection_basic.jl
3131
l2=[Float32(8.311947673061856e-6)],
3232
linf=[Float32(6.627000273229378e-5)],
33-
RealT=Float32)
33+
RealT_for_test_tolerances=Float32)
3434
# Ensure that we do not have excessive memory allocations
3535
# (e.g., from type instabilities)
3636
@test_allocations(Trixi.rhs!, semi, sol, 1000)

test/test_tree_2d_mhd.jl

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -177,7 +177,7 @@ end
177177
0.09208131,
178178
0.14795369,
179179
2.2078211f-6],
180-
RealT=Float32)
180+
RealT_for_test_tolerances=Float32)
181181
# Ensure that we do not have excessive memory allocations
182182
# (e.g., from type instabilities)
183183
@test_allocations(Trixi.rhs!, semi, sol, 1000)
@@ -402,7 +402,7 @@ end
402402
# In the `StepsizeCallback`, though, the less diffusive `max_abs_speeds` is employed which is consistent with `max_abs_speed`.
403403
# Thus, we exchanged in PR#2458 the default wave speed used in the LLF flux to `max_abs_speed`.
404404
# To ensure that every example still runs we specify explicitly `FluxLaxFriedrichs(max_abs_speed_naive)`.
405-
# We remark, however, that the now default `max_abs_speed` is in general recommended due to compliance with the
405+
# We remark, however, that the now default `max_abs_speed` is in general recommended due to compliance with the
406406
# `StepsizeCallback` (CFL-Condition) and less diffusion.
407407
surface_flux=(FluxLaxFriedrichs(max_abs_speed_naive),
408408
flux_nonconservative_powell_local_jump),

0 commit comments

Comments
 (0)