Print Analysis in Full Precision to File (#2155)

* Print in Full Precision

* Apply suggestions from code review

* detect digits automatically

* cons with old vrsion

* cut down whitespaces

* print instead of @printf

* Update src/callbacks_step/analysis.jl

Co-authored-by: Michael Schlottke-Lakemper <[email protected]>

* News entry

* Apply suggestions from code review

Co-authored-by: Joshua Lampert <[email protected]>

* Update NEWS.md

* Bring back comment symbol

* Update NEWS.md

* Update NEWS.md

---------

Co-authored-by: Hendrik Ranocha <[email protected]>
Co-authored-by: Michael Schlottke-Lakemper <[email protected]>
Co-authored-by: Joshua Lampert <[email protected]>

Author: 4 people

NEWS.md

@@ -15,6 +15,11 @@ for human readability.
   [RecursiveArrayTools.jl](https://github.com/SciML/RecursiveArrayTools.jl)
   for `DGMulti` solvers ([#2150]). You can use `Base.parent` to unwrap
   the original data.
+- The `AnalysisCallback` output generated with the `save_analysis = true` option now prints
+  floating point numbers in their respective (full) precision. 
+  Previously, only the first 8 digits were printed to file.
+  Furthermore, the names of the printed fields are now only separated by a single white space, 
+  in contrast to before where this were multiple, depending on the actual name of the printed data.
 
 #### Deprecated
 

src/callbacks_step/analysis.jl

@@ -163,42 +163,42 @@ function initialize!(cb::DiscreteCallback{Condition, Affect!}, u_ode, du_ode, t,
 
         # write header of output file
         open(joinpath(output_directory, analysis_filename), "w") do io
-            @printf(io, "#%-8s", "timestep")
-            @printf(io, "  %-14s", "time")
-            @printf(io, "  %-14s", "dt")
+            print(io, "#timestep ")
+            print(io, "time ")
+            print(io, "dt ")
             if :l2_error in analysis_errors
                 for v in varnames(cons2cons, equations)
-                    @printf(io, "   %-14s", "l2_"*v)
+                    print(io, "l2_" * v * " ")
                 end
             end
             if :linf_error in analysis_errors
                 for v in varnames(cons2cons, equations)
-                    @printf(io, "   %-14s", "linf_"*v)
+                    print(io, "linf_" * v * " ")
                 end
             end
             if :conservation_error in analysis_errors
                 for v in varnames(cons2cons, equations)
-                    @printf(io, "   %-14s", "cons_"*v)
+                    print(io, "cons_" * v * " ")
                 end
             end
             if :residual in analysis_errors
                 for v in varnames(cons2cons, equations)
-                    @printf(io, "   %-14s", "res_"*v)
+                    print(io, "res_" * v * " ")
                 end
             end
             if :l2_error_primitive in analysis_errors
                 for v in varnames(cons2prim, equations)
-                    @printf(io, "   %-14s", "l2_"*v)
+                    print(io, "l2_" * v * " ")
                 end
             end
             if :linf_error_primitive in analysis_errors
                 for v in varnames(cons2prim, equations)
-                    @printf(io, "   %-14s", "linf_"*v)
+                    print(io, "linf_" * v * " ")
                 end
             end
 
             for quantity in analysis_integrals
-                @printf(io, "   %-14s", pretty_form_ascii(quantity))
+                print(io, pretty_form_ascii(quantity), " ")
             end
 
             println(io)
@@ -322,9 +322,9 @@ function (analysis_callback::AnalysisCallback)(u_ode, du_ode, integrator, semi)
         if mpi_isroot() && analysis_callback.save_analysis
             io = open(joinpath(analysis_callback.output_directory,
                                analysis_callback.analysis_filename), "a")
-            @printf(io, "% 9d", iter)
-            @printf(io, "  %10.8e", t)
-            @printf(io, "  %10.8e", dt)
+            print(io, iter)
+            print(io, " ", t)
+            print(io, " ", dt)
         else
             io = devnull
         end
@@ -393,7 +393,7 @@ function (analysis_callback::AnalysisCallback)(io, du, u, u_ode, t, semi)
                 print(" L2 error:    ")
                 for v in eachvariable(equations)
                     @printf("  % 10.8e", l2_error[v])
-                    @printf(io, "  % 10.8e", l2_error[v])
+                    print(io, " ", l2_error[v])
                 end
                 println()
             end
@@ -403,7 +403,7 @@ function (analysis_callback::AnalysisCallback)(io, du, u, u_ode, t, semi)
                 print(" Linf error:  ")
                 for v in eachvariable(equations)
                     @printf("  % 10.8e", linf_error[v])
-                    @printf(io, "  % 10.8e", linf_error[v])
+                    print(io, " ", linf_error[v])
                 end
                 println()
             end
@@ -420,7 +420,7 @@ function (analysis_callback::AnalysisCallback)(io, du, u, u_ode, t, semi)
             for v in eachvariable(equations)
                 err = abs(state_integrals[v] - initial_state_integrals[v])
                 @printf("  % 10.8e", err)
-                @printf(io, "  % 10.8e", err)
+                print(io, " ", err)
             end
             println()
         end
@@ -442,7 +442,7 @@ function (analysis_callback::AnalysisCallback)(io, du, u, u_ode, t, semi)
             end
             if mpi_isroot()
                 @printf("  % 10.8e", res)
-                @printf(io, "  % 10.8e", res)
+                print(io, " ", res)
             end
         end
         mpi_println()
@@ -466,7 +466,7 @@ function (analysis_callback::AnalysisCallback)(io, du, u, u_ode, t, semi)
                 print(" L2 error prim.: ")
                 for v in eachvariable(equations)
                     @printf("%10.8e   ", l2_error_prim[v])
-                    @printf(io, "  % 10.8e", l2_error_prim[v])
+                    print(io, " ", l2_error_prim[v])
                 end
                 println()
             end
@@ -476,7 +476,7 @@ function (analysis_callback::AnalysisCallback)(io, du, u, u_ode, t, semi)
                 print(" Linf error pri.:")
                 for v in eachvariable(equations)
                     @printf("%10.8e   ", linf_error_prim[v])
-                    @printf(io, "  % 10.8e", linf_error_prim[v])
+                    print(io, " ", linf_error_prim[v])
                 end
                 println()
             end
@@ -581,7 +581,7 @@ function analyze_integrals(analysis_integrals::NTuple{N, Any}, io, du, u, t,
     if mpi_isroot()
         @printf(" %-12s:", pretty_form_utf(quantity))
         @printf("  % 10.8e", res)
-        @printf(io, "  % 10.8e", res)
+        print(io, " ", res)
     end
     mpi_println()