return nothing where nothing is returned (#2516)

* `return nothing` where nothing is returned

* more

Author: DanielDoehring

src/callbacks_stage/entropy_bounded_limiter.jl

@@ -56,6 +56,8 @@ function (limiter!::EntropyBoundedLimiter)(u_ode, integrator,
         limiter_entropy_bounded!(u, u_prev, limiter!.exp_entropy_decrease_max,
                                  mesh_equations_solver_cache(semi)...)
     end
+
+    return nothing
 end
 
 # Exponentiated entropy change for the thermodynamic entropy (see `entropy_thermodynamic`) 

src/callbacks_stage/positivity_zhang_shu.jl

@@ -36,6 +36,8 @@ function (limiter!::PositivityPreservingLimiterZhangShu)(u_ode, integrator,
         limiter_zhang_shu!(u, limiter!.thresholds, limiter!.variables,
                            mesh_equations_solver_cache(semi)...)
     end
+
+    return nothing
 end
 
 # Iterate over tuples in a type-stable way using "lispy tuple programming",

src/callbacks_step/amr_dg.jl

@@ -89,6 +89,8 @@ function rebalance_solver!(u_ode::AbstractVector,
             MPI.Waitall(requests, MPI.Status)
         end
     end # GC.@preserve old_u_ode
+
+    return nothing
 end
 
 # Construct cache for ControllerThreeLevel and ControllerThreeLevelCombined.

src/callbacks_step/amr_dg1d.jl

@@ -282,5 +282,7 @@ function coarsen_elements!(u::AbstractArray{<:Any, 3}, element_id,
         # Update value
         set_node_vars!(u, acc, equations, dg, i, element_id)
     end
+
+    return nothing
 end
 end # @muladd

src/callbacks_step/amr_dg2d.jl

@@ -74,6 +74,8 @@ function rebalance_solver!(u_ode::AbstractVector, mesh::TreeMesh{2}, equations,
             MPI.Waitall(requests, MPI.Status)
         end
     end # GC.@preserve old_u_ode
+
+    return nothing
 end
 
 # Refine elements in the DG solver based on a list of cell_ids that should be refined.

src/callbacks_step/callbacks_step.jl

@@ -9,7 +9,7 @@
 # that should be saved
 function get_element_variables!(element_variables, u, mesh, equations, solver, cache,
                                 callback; kwargs...)
-    nothing
+    return nothing
 end
 
 @inline function get_element_variables!(element_variables, u_ode,

src/callbacks_step/save_solution.jl

@@ -276,6 +276,8 @@ end
                                                              element_variables,
                                                              solution_callback.node_variables,
                                                              system = system)
+
+    return nothing
 end
 
 @inline function save_solution_file(u_ode, t, dt, iter,
@@ -289,6 +291,8 @@ end
                        solution_callback,
                        element_variables,
                        node_variables; system = system)
+
+    return nothing
 end
 
 # TODO: Taal refactor, move save_mesh_file?

src/callbacks_step/time_series_dg_tree.jl

@@ -114,6 +114,8 @@ function record_state_at_points!(point_data, u, solution_variables,
             end
         end
     end
+
+    return nothing
 end
 
 # Record the solution variables at each given point for the 2D case
@@ -147,6 +149,8 @@ function record_state_at_points!(point_data, u, solution_variables,
             end
         end
     end
+
+    return nothing
 end
 
 # Record the solution variables at each given point for the 3D case
@@ -181,5 +185,7 @@ function record_state_at_points!(point_data, u, solution_variables,
             end
         end
     end
+
+    return nothing
 end
 end # @muladd

src/callbacks_step/time_series_dg_unstructured.jl

@@ -301,5 +301,7 @@ function record_state_at_points!(point_data, u, solution_variables,
             end
         end
     end
+
+    return nothing
 end
 end # @muladd

src/meshes/structured_mesh_view.jl

@@ -105,6 +105,8 @@ function calc_node_coordinates!(node_coordinates, element,
         node_coordinates[:, i, j, element] .= mapping(cell_x_offset + dx / 2 * nodes[i],
                                                       cell_y_offset + dy / 2 * nodes[j])
     end
+
+    return nothing
 end
 
 # Does not save the mesh itself to an HDF5 file. Instead saves important attributes