-
Notifications
You must be signed in to change notification settings - Fork 136
Open
Labels
enhancementNew feature or requestNew feature or request
Description
This is basically taken from #1136. Currently, our idea is to merge the DGMulti setup from that PR into dev, draft a corresponding TreeMesh & DGSEM version in another PR, and see how it looks for Navier-Stokes. When that's okay, we can go ahead and merge dev into main to finally get support for parabolic terms in Trixi.jl.
-
TreeMeshversion withDGSEM- BR1
- LDG Add
ViscousFormulationLDGsupport toTreeMesh#2333 - Mortars
- AMR for
TreeMesh - AMR for
P4estMesh - 1D
- 2D
- 3D Compressible Navier-Stokes on TreeMesh3D #1239
-
P4estMesh- LDG
- Interfaces LDG for interfaces
P4estMesh#2689 - Mortars
- Interfaces LDG for interfaces
- LDG
-
StructuredMesh - Navier-Stokes
- Decide on which non-dimensional scaling to use.
- Add a parabolic solver field (or at least a way to specify parabolic numerical parameters)
- Add parabolic penalty terms which depend on
jump(u) - Where should penalty terms live: equations, solver, or the elixir itself? These terms will probably need to be specialized for every single equation.
- Add parabolic penalty terms which depend on
- Should we have "default" BC behavior (e.g., "boundary_condition_use_inner_state / boundary_condition_do_nothing")? Answer: no. The user should be required to specify this explicitly.
- Should the viscous flux depend on
orientation(i.e., computexandycomponents separately)? - Decide how general we want the BCs to be
- What data should be made available to parabolic BCs? Solution values? Gradient values? Viscous flux values?
- Right now, we keep it simple for now, just pass in solution values
- Docstrings
- Documentation, examples, tutorial
- Explain
Gradient/Divergenceboundary conditions in docs - Add a Literate tutorial for compressible Navier-Stokes
- Explain
- Naming things
-
grad_u(current) vs.gradientsorgradients_u -
no_boundary_condition(current) vs.boundary_condition_do_nothingor something else (what?). Answer:boundary_condition_do_nothing - Types for viscous methods like BR1, LDG? Current naming is
ViscousFormulation***but this gets pretty long.
-
- Gradient variables
- Keep track of number of gradient variables and output which gradient variables are used from the parabolic equations constructor.
- Address potential inefficiencies of converting back and forth the gradient variables (see also here)
- Avoid need for defining diffusivity through global functions Initial condition for parabolic terms requires defining
diffusivityas global function #1503
- Add an "enstrophy" callback as a proof of concept issue with "combined" equations. Compressible Navier-Stokes on TreeMesh3D #1239
- Add experimental notes to all exported and/or docstring'd methods/types.
- Rename
elixir_navier_stokes_xxx.jltoelixir_navierstokes_xxx.jlfor consistency (e.g., withelixir_shallowwater_xxx.jl). -
StepsizeCallbackwith viscous CFL condition-
TreeMesh -
P4estMeshDiffusive CFLP4est#2696
-
Metadata
Metadata
Assignees
Labels
enhancementNew feature or requestNew feature or request