no reference values

Author: benegee

test/test_3d_shallow_water.jl

@@ -11,17 +11,17 @@ EXAMPLES_DIR = TrixiAtmo.examples_dir()
     @test_trixi_include(joinpath(EXAMPLES_DIR,
                                  "elixir_shallowwater_cartesian_unsteady_solid_body_rotation_EC_correction.jl"),
                         l2=[
-                            0.1385840313143962,
-                            0.82837506217066,
-                            0.1401783834081,
-                            0.3170683216476,
+                            0.0274954994,
+                            9.65117289,
+                            8.20257340,
+                            18.5292301,
                             0.0
                         ],
                         linf=[
-                            0.159323444366919,
-                            0.7491913049016,
-                            0.553600463765,
-                            0.0452131916827,
+                            0.157738035,
+                            59.4123680,
+                            51.9233503,
+                            8.36833383,
                             0.0
                         ],
                         polydeg=3,

test/test_spherical_advection.jl

@@ -11,17 +11,17 @@ EXAMPLES_DIR = TrixiAtmo.examples_dir()
     @test_trixi_include(joinpath(EXAMPLES_DIR,
                                  "elixir_shallowwater_cartesian_advection_cubed_sphere.jl"),
                         l2=[
-                            0.0,
-                            0.317829852384286,
-                            0.810001095524816,
-                            0.317829852393054,
+                            0.183524336,
+                            5.64470440,
+                            2.80467667,
+                            5.64470440,
                             0.0
                         ],
                         linf=[
-                            0.872101731709677,
-                            0.6515963524798,
-                            0.1288712006542,
-                            0.65159635247255,
+                            2.79650356,
+                            91.6208734,
+                            24.9330974,
+                            91.6208734,
                             0.0
                         ])
     # and small reference values
@@ -39,17 +39,17 @@ end
     @test_trixi_include(joinpath(EXAMPLES_DIR,
                                  "elixir_shallowwater_cartesian_advection_quad_icosahedron.jl"),
                         l2=[
-                            0.0,
-                            0.807355540175404,
-                            0.311881740745649,
-                            0.807355540181993,
+                            0.0771325788,
+                            2.24899209,
+                            1.45355192,
+                            2.24899209,
                             0.0
                         ],
                         linf=[
-                            0.591965583200476,
-                            0.76418895396273,
-                            0.69731833993228,
-                            0.76418895397,
+                            1.18929523,
+                            34.1427583,
+                            17.9760460,
+                            34.1427583,
                             0.0
                         ])
     # and small reference values
@@ -67,17 +67,17 @@ end
     @test_trixi_include(joinpath(EXAMPLES_DIR,
                                  "elixir_shallowwater_cartesian_advection_cubed_sphere.jl"),
                         l2=[
-                            0.8933429672952714,
-                            0.84887991902509,
-                            0.758850586757735,
-                            0.84887991902542,
+                            0.222179190,
+                            6.74419737,
+                            3.36551000,
+                            6.74419737,
                             0.0
                         ],
                         linf=[
-                            0.289456304624764,
-                            0.6958334067349,
-                            0.59259301602742,
-                            0.69583340674217,
+                            3.60436608,
+                            113.572183,
+                            30.1250336,
+                            113.572183,
                             0.0
                         ], element_local_mapping=true)
     # and small reference values

test/test_trixiatmo.jl

@@ -21,43 +21,16 @@ macro test_trixi_include(elixir, args...)
     local linf = get_kwarg(args, :linf, nothing)
     local atol = get_kwarg(args, :atol, 500 * eps())
     local rtol = get_kwarg(args, :rtol, sqrt(eps()))
-    local skip_coverage = get_kwarg(args, :skip_coverage, false)
-    local coverage_override = expr_to_named_tuple(get_kwarg(args, :coverage_override, :()))
-    if !(:maxiters in keys(coverage_override))
-        # maxiters in coverage_override defaults to 1
-        coverage_override = (; coverage_override..., maxiters = 1)
-    end
-
     local cmd = string(Base.julia_cmd())
-    local coverage = occursin("--code-coverage", cmd) &&
-                     !occursin("--code-coverage=none", cmd)
 
     local kwargs = Pair{Symbol, Any}[]
     for arg in args
         if (arg.head == :(=) &&
-            !(arg.args[1] in (:l2, :linf, :atol, :rtol, :coverage_override, :skip_coverage))
-            && !(coverage && arg.args[1] in keys(coverage_override)))
+            !(arg.args[1] in (:l2, :linf, :atol, :rtol)))
             push!(kwargs, Pair(arg.args...))
         end
     end
 
-    if coverage
-        for key in keys(coverage_override)
-            push!(kwargs, Pair(key, coverage_override[key]))
-        end
-    end
-
-    if coverage && skip_coverage
-        return quote
-            if TrixiAtmo.Trixi.mpi_isroot()
-                println("═"^100)
-                println("Skipping coverage test of ", $elixir)
-                println("═"^100)
-                println("\n\n")
-            end
-        end
-    end
-
     quote
         TrixiAtmo.Trixi.mpi_isroot() && println("═"^100)
         TrixiAtmo.Trixi.mpi_isroot() && println($elixir)
@@ -76,7 +49,7 @@ macro test_trixi_include(elixir, args...)
         @test_nowarn_mod TrixiAtmo.Trixi.trixi_include(@__MODULE__, $elixir; $kwargs...) additional_ignore_content
 
         # if present, compare l2 and linf errors against reference values
-        if !$coverage && (!isnothing($l2) || !isnothing($linf))
+        if !isnothing($l2) || !isnothing($linf)
             l2_measured, linf_measured = analysis_callback(sol)
 
             if TrixiAtmo.Trixi.mpi_isroot() && !isnothing($l2)