initial condition with outer layer data

Author: benegee

examples/moist_euler/rainy_bubble/elixir_rainy_euler_rainy_bubble.jl

@@ -14,7 +14,12 @@ coordinates_max = (2400.0, 2400.0)
 
 # create layers for initial condition
 equations = CompressibleRainyEulerEquations2D()
-layers = AtmosphereLayersRainyBubble(equations; total_height = coordinates_max[2] + 1)
+atmosphere_data = AtmosphereLayersRainyBubble(equations; total_height = coordinates_max[2] + 1)
+
+# Create the initial condition with the initial data set
+function initial_condition_rainy(x, t, equations::CompressibleRainyEulerEquations2D)
+    return initial_condition_bubble_rainy(x, t, equations; atmosphere_data)
+end
 
 ###############################################################################
 # semidiscretization of the compressible rainy Euler equations
@@ -35,7 +40,7 @@ cells_per_dimension = (64, 64)
 mesh = StructuredMesh(cells_per_dimension, coordinates_min, coordinates_max,
                       periodicity = (true, false))
 
-semi = SemidiscretizationHyperbolic(mesh, equations, initial_condition_bubble_rainy, solver,
+semi = SemidiscretizationHyperbolic(mesh, equations, initial_condition_rainy, solver,
                                     source_terms = source_terms_rainy,
                                     boundary_conditions = boundary_conditions)
 

examples/moist_euler/rainy_bubble/elixir_rainy_euler_rainy_bubble_diffusion.jl

@@ -17,7 +17,12 @@ coordinates_max = (2400.0, 2400.0)
 
 # create layers for initial condition
 equations = CompressibleRainyEulerEquations2D()
-layers = AtmosphereLayersRainyBubble(equations; total_height = coordinates_max[2] + 1)
+atmosphere_data = AtmosphereLayersRainyBubble(equations; total_height = coordinates_max[2] + 1)
+
+# Create the initial condition with the initial data set
+function initial_condition_rainy(x, t, equations::CompressibleRainyEulerEquations2D)
+    return initial_condition_bubble_rainy(x, t, equations; atmosphere_data)
+end
 
 ###############################################################################
 # semidiscretization of the compressible rainy Euler equations
@@ -42,16 +47,14 @@ volume_integral = VolumeIntegralFluxDifferencing(flux_ec_rain)
 
 solver = DGSEM(polydeg, surface_flux, volume_integral)
 
-initial_condition = initial_condition_bubble_rainy
-source_terms = source_terms_rainy
-
 initial_refinement_level = 6
 mesh = TreeMesh(coordinates_min, coordinates_max,
                 initial_refinement_level = initial_refinement_level,
                 periodicity = (true, false), n_cells_max = 1_000_000)
 
 semi = SemidiscretizationHyperbolicParabolic(mesh, (equations, equations_parabolic),
-                                             initial_condition, solver; source_terms,
+                                             initial_condition_rainy, solver;
+                                             source_terms_rainy,
                                              boundary_conditions = (boundary_conditions,
                                                                     boundary_conditions_parabolic))
 

src/equations/compressible_rainy_euler_2d.jl

@@ -1130,7 +1130,7 @@ end
 
 function initial_condition_bubble_rainy(x, t,
                                         equations::CompressibleRainyEulerEquations2D;
-                                        atmosphere_layers = layers)
+                                        atmosphere_layers)
     # equations constants
     c_vd = equations.c_dry_air_const_volume
     c_vv = equations.c_vapour_const_volume

src/equations/reference_data.jl

@@ -2,9 +2,9 @@
 #! format: noindent
 
 # Physical constants in SI units (reference values from the Williamson et al. test suite)
-const EARTH_RADIUS = 6.37122e6  # m
+const EARTH_RADIUS = 6.371229 # 6.37122e6  # m
 const EARTH_GRAVITATIONAL_ACCELERATION = 9.81 # 9.80616  # m/s²
-const EARTH_ROTATION_RATE = 7.292e-5  # rad/s
+const EARTH_ROTATION_RATE = 7.29212 # 7.292e-5  # rad/s
 const SECONDS_PER_DAY = 8.64e4
 
 @doc raw"""